From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Fix building on x86 OpenBSD 4.3
Date: Wed, 06 Aug 2008 15:11:00 -0000 [thread overview]
Message-ID: <200808061610.44404.pedro@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
Hi,
In my testing on several targets, I noticed that GDB isn't
building on x86 OpenBSD 4.3, due to the fact that struct
switchframe got its sf_ppl member removed, and GDB is trying
to access it.
I can't claim I know a think about this, but,
The patch that seems to have removed it, shows that is was always
0 just before removal:
http://archive.netbsd.se/?ml=openbsd-tech&a=2007-09&m=5239543
And I can see it being set to != 0 in that files' history at:
http://opengrok.creo.hu/openbsd/history/src/sys/arch/i386/i386/vm_machdep.c
So, I guess that the attached is the best to do, and I didn't
notice any breakage. Of course, I don't even know what
triggers this code path. :-)
Mark, perhaps you have a better fix in your local trees?
OK?
--
Pedro Alves
[-- Attachment #2: obsd_build_4.3.diff --]
[-- Type: text/x-diff, Size: 1775 bytes --]
2008-08-06 Pedro Alves <pedro@codesourcery.com>
* i386obsd-nat.c (i386obsd_supply_pcb): Remove handling of
switchframe.sf_ppl != 0.
---
gdb/i386obsd-nat.c | 21 ++++++---------------
1 file changed, 6 insertions(+), 15 deletions(-)
Index: src/gdb/i386obsd-nat.c
===================================================================
--- src.orig/gdb/i386obsd-nat.c 2008-01-01 22:53:11.000000000 +0000
+++ src/gdb/i386obsd-nat.c 2008-08-06 16:00:41.000000000 +0100
@@ -61,21 +61,12 @@ i386obsd_supply_pcb (struct regcache *re
checking if the saved interrupt priority level in the stack frame
looks reasonable.. */
read_memory (pcb->pcb_esp, (char *) &sf, sizeof sf);
- if ((unsigned int) sf.sf_ppl < 0x100 && (sf.sf_ppl & 0xf) == 0)
- {
- /* Yes, we have a frame that matches cpu_switch(). */
- pcb->pcb_esp += sizeof (struct switchframe);
- regcache_raw_supply (regcache, I386_EDI_REGNUM, &sf.sf_edi);
- regcache_raw_supply (regcache, I386_ESI_REGNUM, &sf.sf_esi);
- regcache_raw_supply (regcache, I386_EBX_REGNUM, &sf.sf_ebx);
- regcache_raw_supply (regcache, I386_EIP_REGNUM, &sf.sf_eip);
- }
- else
- {
- /* No, the pcb must have been last updated by savectx(). */
- pcb->pcb_esp += 4;
- regcache_raw_supply (regcache, I386_EIP_REGNUM, &sf);
- }
+
+ pcb->pcb_esp += sizeof (struct switchframe);
+ regcache_raw_supply (regcache, I386_EDI_REGNUM, &sf.sf_edi);
+ regcache_raw_supply (regcache, I386_ESI_REGNUM, &sf.sf_esi);
+ regcache_raw_supply (regcache, I386_EBX_REGNUM, &sf.sf_ebx);
+ regcache_raw_supply (regcache, I386_EIP_REGNUM, &sf.sf_eip);
regcache_raw_supply (regcache, I386_EBP_REGNUM, &pcb->pcb_ebp);
regcache_raw_supply (regcache, I386_ESP_REGNUM, &pcb->pcb_esp);
next reply other threads:[~2008-08-06 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 15:11 Pedro Alves [this message]
2008-08-06 15:23 ` Mark Kettenis
2008-08-06 15:28 ` Mark Kettenis
2008-08-06 15:33 ` Pedro Alves
2008-08-06 15:52 ` Mark Kettenis
2008-08-06 20:04 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808061610.44404.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox