Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: vladimir@codesourcery.com, gdb-patches@sources.redhat.com
Subject: GDB/MI PING (was: "Re: RFA: Remove gdb-events")
Date: Mon, 21 Jul 2008 16:54:00 -0000	[thread overview]
Message-ID: <20080721165355.GA3837@adacore.com> (raw)
In-Reply-To: <m37ibkxeo1.fsf@fleche.redhat.com>

Hi Vladimir,

Tom made some changes in MI source files. They should not affect MI
behavior at all, and they look fine to me, but I thought you might
want to have a look.

    http://www.sourceware.org/ml/gdb-patches/2008-07/msg00244.html

Hey Tom,

> Joel> Eli: if you could take a look at the documentation of the new
> Joel> observers, that would be great! I'm going to approve the
> Joel> technical part, and we'll follow any suggestion you might have
> Joel> either before or after commit.
> 
> Joel> Vladimir: This patch touches MI. Could you take a look at this part
> Joel> of the patch? The changes seem fine to me, but see below my suggestion.
> 
> I'm waiting for these two, so I haven't sent an updated patch.
> But...

I see Eli answered, so let's now wait for Vladimir - I think he just
missed this email (so I changed the subject to contain "MI" to catch
his attention).

> I checked and all the dependencies are there, afaict.  I think you
> just misread the tracepoint.o hunk.  See the second insertion:

Argh, you are right. Sorry about that.

You should commit your change as soon as Vladimir OKs the MI part.
I'm almost tempted to say that you should commit them now, and fix
any comment that Vladimir might have as a followup patch, but Vladimir
is usually extremely responsive.

-- 
Joel


  reply	other threads:[~2008-07-21 16:54 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-13  0:16 RFA: Remove gdb-events Tom Tromey
2008-07-13  3:26 ` Stan Shebs
2008-07-13 21:56   ` Tom Tromey
2008-08-01 16:20     ` Tom Tromey
2008-08-01 16:33       ` Subdir ChangeLogs (was Re: RFA: Remove gdb-events) Stan Shebs
2008-08-01 17:10         ` Subdir ChangeLogs Tom Tromey
2008-08-01 17:27           ` Stan Shebs
2008-08-01 17:54             ` Tom Tromey
2008-08-01 18:44             ` Eli Zaretskii
2008-08-01 18:55               ` Tom Tromey
2008-08-01 19:25                 ` Eli Zaretskii
2008-08-01 19:33                   ` Tom Tromey
2008-08-01 20:11                     ` Thiago Jung Bauermann
2008-08-02  7:13                     ` Eli Zaretskii
2008-08-02 16:52                       ` Tom Tromey
2008-08-02 17:28                         ` Eli Zaretskii
2008-08-02 20:24                         ` Thiago Jung Bauermann
2008-08-03  0:02           ` Michael Snyder
2008-08-01 17:40       ` RFA: Remove gdb-events Mark Kettenis
2008-07-14 17:10 ` Joel Brobecker
2008-07-14 20:33   ` Tom Tromey
2008-07-15  6:54     ` Joel Brobecker
2008-07-17 23:41   ` Tom Tromey
2008-07-21 16:54     ` Joel Brobecker [this message]
2008-07-22  0:56     ` Tom Tromey
2008-07-25 16:11       ` Tom Tromey
2008-07-20 11:46 ` Eli Zaretskii
2008-07-21 17:13 ` Vladimir Prus
2008-07-22  0:32   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080721165355.GA3837@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=tromey@redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox