Re: [MI non-stop 05/11, RFA] -exec-continue/-exec-interrupt --all

[Vladimir Prus <vladimir@codesourcery.com>]

On Sunday 13 July 2008 08:24:47 Daniel Jacobowitz wrote:
> On Fri, Jul 11, 2008 at 09:34:34AM -0400, Daniel Jacobowitz wrote:
> > > @@ -177,8 +177,12 @@ mi_cmd_exec_return (char *command, char **argv, int argc)
> > >  void
> > >  mi_cmd_exec_continue (char *command, char **argv, int argc)
> > >  {
> > > -  /* FIXME: Should call a libgdb function, not a cli wrapper.  */
> > > -  return mi_execute_async_cli_command ("continue", argv, argc);
> > > +  if (argc == 0)
> > > +    continue_1 (0);
> > > +  else if (argc == 1 && strcmp (argv[0], "--all") == 0)
> > > +    continue_1 (1);
> > > +  else
> > > +    error ("Usage: -exec-continue [--all]");
> > >  }
> > >  
> > >  /* Interrupt the execution of the target.  Note how we must play around
> > 
> > I suggest you use mi_getopt instead, for consistency.
> 
> Did you notice this comment?

Yes. mi_getopt is not capable of handling --all. It can only handle -a, which
seems ugly to me.

> Also, please remember to post the version of patches that you check
> in.

OK, will do.

- Volodya