Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>,
		gdb-patches@sources.redhat.com
Subject: Re: [MI non-stop 05/11, RFA] -exec-continue/-exec-interrupt --all
Date: Sun, 13 Jul 2008 04:25:00 -0000	[thread overview]
Message-ID: <20080713042447.GA30405@caradoc.them.org> (raw)
In-Reply-To: <20080711133434.GA2651@caradoc.them.org>

On Fri, Jul 11, 2008 at 09:34:34AM -0400, Daniel Jacobowitz wrote:
> > @@ -177,8 +177,12 @@ mi_cmd_exec_return (char *command, char **argv, int argc)
> >  void
> >  mi_cmd_exec_continue (char *command, char **argv, int argc)
> >  {
> > -  /* FIXME: Should call a libgdb function, not a cli wrapper.  */
> > -  return mi_execute_async_cli_command ("continue", argv, argc);
> > +  if (argc == 0)
> > +    continue_1 (0);
> > +  else if (argc == 1 && strcmp (argv[0], "--all") == 0)
> > +    continue_1 (1);
> > +  else
> > +    error ("Usage: -exec-continue [--all]");
> >  }
> >  
> >  /* Interrupt the execution of the target.  Note how we must play around
> 
> I suggest you use mi_getopt instead, for consistency.

Did you notice this comment?

Also, please remember to post the version of patches that you check
in.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-07-13  4:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-28 16:56 Vladimir Prus
2008-06-28 18:17 ` Marc Khouzam
2008-06-29  6:05   ` Vladimir Prus
2008-06-28 20:28 ` Tom Tromey
2008-06-29 17:37   ` Vladimir Prus
2008-07-11 13:34 ` Daniel Jacobowitz
2008-07-13  4:25   ` Daniel Jacobowitz [this message]
2008-07-13  4:36     ` Vladimir Prus
2008-07-13 14:32       ` Daniel Jacobowitz
2008-07-13 16:24         ` Vladimir Prus
2008-07-13 22:35       ` Nick Roberts
2008-07-13  5:50 ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080713042447.GA30405@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox