From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29398 invoked by alias); 13 Jul 2008 04:25:16 -0000 Received: (qmail 28899 invoked by uid 22791); 13 Jul 2008 04:25:14 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 13 Jul 2008 04:24:51 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7623298415; Sun, 13 Jul 2008 04:24:49 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 476989809E; Sun, 13 Jul 2008 04:24:49 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KHt8h-0007zc-SS; Sun, 13 Jul 2008 00:24:47 -0400 Date: Sun, 13 Jul 2008 04:25:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [MI non-stop 05/11, RFA] -exec-continue/-exec-interrupt --all Message-ID: <20080713042447.GA30405@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200806282045.39438.vladimir@codesourcery.com> <20080711133434.GA2651@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080711133434.GA2651@caradoc.them.org> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00247.txt.bz2 On Fri, Jul 11, 2008 at 09:34:34AM -0400, Daniel Jacobowitz wrote: > > @@ -177,8 +177,12 @@ mi_cmd_exec_return (char *command, char **argv, int argc) > > void > > mi_cmd_exec_continue (char *command, char **argv, int argc) > > { > > - /* FIXME: Should call a libgdb function, not a cli wrapper. */ > > - return mi_execute_async_cli_command ("continue", argv, argc); > > + if (argc == 0) > > + continue_1 (0); > > + else if (argc == 1 && strcmp (argv[0], "--all") == 0) > > + continue_1 (1); > > + else > > + error ("Usage: -exec-continue [--all]"); > > } > > > > /* Interrupt the execution of the target. Note how we must play around > > I suggest you use mi_getopt instead, for consistency. Did you notice this comment? Also, please remember to post the version of patches that you check in. -- Daniel Jacobowitz CodeSourcery