From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19407 invoked by alias); 13 Jul 2008 04:36:40 -0000 Received: (qmail 19399 invoked by uid 22791); 13 Jul 2008 04:36:39 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 13 Jul 2008 04:36:21 +0000 Received: (qmail 17446 invoked from network); 13 Jul 2008 04:36:19 -0000 Received: from unknown (HELO 172.16.unknown.plus.ru) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Jul 2008 04:36:19 -0000 From: Vladimir Prus To: gdb-patches@sources.redhat.com Subject: Re: [MI non-stop 05/11, RFA] -exec-continue/-exec-interrupt --all Date: Sun, 13 Jul 2008 04:36:00 -0000 User-Agent: KMail/1.9.9 References: <200806282045.39438.vladimir@codesourcery.com> <20080711133434.GA2651@caradoc.them.org> <20080713042447.GA30405@caradoc.them.org> In-Reply-To: <20080713042447.GA30405@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807130836.22263.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00252.txt.bz2 On Sunday 13 July 2008 08:24:47 Daniel Jacobowitz wrote: > On Fri, Jul 11, 2008 at 09:34:34AM -0400, Daniel Jacobowitz wrote: > > > @@ -177,8 +177,12 @@ mi_cmd_exec_return (char *command, char **argv, int argc) > > > void > > > mi_cmd_exec_continue (char *command, char **argv, int argc) > > > { > > > - /* FIXME: Should call a libgdb function, not a cli wrapper. */ > > > - return mi_execute_async_cli_command ("continue", argv, argc); > > > + if (argc == 0) > > > + continue_1 (0); > > > + else if (argc == 1 && strcmp (argv[0], "--all") == 0) > > > + continue_1 (1); > > > + else > > > + error ("Usage: -exec-continue [--all]"); > > > } > > > > > > /* Interrupt the execution of the target. Note how we must play around > > > > I suggest you use mi_getopt instead, for consistency. > > Did you notice this comment? Yes. mi_getopt is not capable of handling --all. It can only handle -a, which seems ugly to me. > Also, please remember to post the version of patches that you check > in. OK, will do. - Volodya