From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] use filename_completer for add_setshow_optional_filename_cmd
Date: Fri, 04 Jul 2008 06:17:00 -0000 [thread overview]
Message-ID: <20080704061700.GB18019@adacore.com> (raw)
In-Reply-To: <000001c8dbc2$b1d7afe0$15870fa0$@u-strasbg.fr>
> There are currently only three adffected commands:
>
> "set debug-file-directory"
> "set args"
> "set solib-search-path"
>
> Only the second one might be questionable, but I also find that it
> is reasonable to have filename completion for "set args" as this is
> now done on most shells.
I also agree that this is more useful than completing on symbols.
> 2008-07-01 Pierre Muller <muller@ics.u-strasbg.fr>
>
> cli/cli-decode.c (add_setshow_optional_filename_cmd): Set
> completer for set to filename_completer.
This change makes sense. Can you submit a NEWS entry describing the
new completion policy? The code update itself is approved.
Thank you,
--
Joel
next prev parent reply other threads:[~2008-07-04 6:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 21:38 Pierre Muller
2008-07-01 22:03 ` Pedro Alves
2008-07-04 6:17 ` Joel Brobecker [this message]
2008-07-04 14:56 ` Pierre Muller
2008-07-04 18:01 ` Eli Zaretskii
2008-07-04 22:56 ` Pierre Muller
2008-07-04 10:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080704061700.GB18019@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox