RE: [RFA] use filename_completer for add_setshow_optional_filename_cmd

["Pierre Muller" <muller@ics.u-strasbg.fr>]

What about this for NEWS:

diff -u -p -r1.277 NEWS
--- gdb/NEWS	11 Jun 2008 12:56:36 -0000	1.277
+++ gdb/NEWS	4 Jul 2008 11:35:19 -0000
@@ -3,6 +3,9 @@
 
 *** Changes since GDB 6.8
 
+* Commands `set debug-file-directory', `set solib-search-path' and `set
args'
+now complete on file names.
+
 * When completing in expressions, gdb will attempt to limit
 completions to allowable structure or union fields, where appropriate.
 For instance, consider:


The only problem is that for `set args' ,
there is a similar claim in NEWS dating back from
GDB 5.1 release....



> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : Friday, July 04, 2008 8:17 AM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] use filename_completer for
> add_setshow_optional_filename_cmd
> 
> > There are currently only three adffected commands:
> >
> > "set debug-file-directory"
> > "set args"
> > "set solib-search-path"
> >
> > Only the second one might be questionable, but I also find that it
> > is reasonable to have filename completion for "set args" as this is
> > now done on most shells.
> 
> I also agree that this is more useful than completing on symbols.
> 
> > 2008-07-01  Pierre Muller  <muller@ics.u-strasbg.fr>
> >
> > 	cli/cli-decode.c (add_setshow_optional_filename_cmd): Set
> > 	completer for set to filename_completer.
> 
> This change makes sense. Can you submit a NEWS entry describing the
> new completion policy? The code update itself is approved.
> 
> Thank you,
> --
> Joel