From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-57039-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32120 invoked by alias); 4 Jul 2008 06:17:23 -0000
Received: (qmail 32111 invoked by uid 22791); 4 Jul 2008 06:17:21 -0000
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 04 Jul 2008 06:17:04 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) 	by filtered-rock.gnat.com (Postfix) with ESMTP id 694972A9742; 	Fri,  4 Jul 2008 02:17:02 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1]) 	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) 	with LMTP id VNVfah8sKH11; Fri,  4 Jul 2008 02:17:02 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) 	by rock.gnat.com (Postfix) with ESMTP id 388D12A9714; 	Fri,  4 Jul 2008 02:17:02 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id 1E7FCE7ACD; Fri,  4 Jul 2008 02:17:00 -0400 (EDT)
Date: Fri, 04 Jul 2008 06:17:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] use filename_completer for add_setshow_optional_filename_cmd
Message-ID: <20080704061700.GB18019@adacore.com>
References: <000001c8dbc2$b1d7afe0$15870fa0$@u-strasbg.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000001c8dbc2$b1d7afe0$15870fa0$@u-strasbg.fr>
User-Agent: Mutt/1.4.2.2i
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-07/txt/msg00051.txt.bz2

> There are currently only three adffected commands:
> 
> "set debug-file-directory"
> "set args"
> "set solib-search-path"
> 
> Only the second one might be questionable, but I also find that it
> is reasonable to have filename completion for "set args" as this is
> now done on most shells.

I also agree that this is more useful than completing on symbols.

> 2008-07-01  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
> 	cli/cli-decode.c (add_setshow_optional_filename_cmd): Set
> 	completer for set to filename_completer.

This change makes sense. Can you submit a NEWS entry describing the
new completion policy? The code update itself is approved.

Thank you,
-- 
Joel