From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: [MI non-stop 07/11, RFA] Allow all CLI command even if target is executing.
Date: Sat, 28 Jun 2008 16:58:00 -0000 [thread overview]
Message-ID: <200806282055.45829.vladimir@codesourcery.com> (raw)
There are several strategies to accepting commands when inferior_ptid is
running. One approach is to plain disallow all commands when inferior_ptid
is running. This seems too strict. Clearly, setting ignore count of
a breakpoint does not require any access to the target at all. Another
approach is to document which commands may be allowed when the target is
running. The problem is that each individual command may work or not work
depending on the properties of the target.
So, it's better to allow all commands up-front, and emit an error if we
try an operation that the current target does not allow. This way, we'll
never mistakenly prevent an operation that the target actually can perform.
In case of error, the frontend may show the error to the user, and user
change either change his mind, or explicitly stop a thread, or ask the
frontend to implicitly interrupt the target, or ask gdb to do same.
OK?
- Volodya
* gdb/top.c (execute_command_1): Don't check if the inferiour
is running.
---
gdb/top.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/gdb/top.c b/gdb/top.c
index e09ccaa..a891a43 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -444,14 +444,6 @@ execute_command_1 (char *p, int from_tty, int internal)
&& !get_cmd_no_selected_thread_ok (c))
error (_("\
Cannot execute this command without a selected thread. See `help thread'"));
- /* If the target is running, we allow only a limited set of
- commands. */
- else if (target_can_async_p ()
- && target_has_execution
- && ((!non_stop && any_running ())
- || (non_stop && is_running (inferior_ptid)))
- && !get_cmd_async_ok (c))
- error (_("Cannot execute this command while the target is running."));
/* Pass null arg rather than an empty one. */
arg = *p ? p : 0;
--
1.5.3.5
next reply other threads:[~2008-06-28 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 16:58 Vladimir Prus [this message]
2008-07-11 13:46 ` Pedro Alves
2008-07-11 18:59 ` Vladimir Prus
2008-07-11 19:04 ` Daniel Jacobowitz
2008-07-11 19:12 ` Pedro Alves
2008-07-13 4:26 ` Daniel Jacobowitz
2008-07-13 4:35 ` Vladimir Prus
2008-07-11 13:46 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806282055.45829.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox