Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [MI non-stop 07/11, RFA] Allow all CLI command even if target 	is executing.
Date: Fri, 11 Jul 2008 13:46:00 -0000	[thread overview]
Message-ID: <20080711134548.GD2651@caradoc.them.org> (raw)
In-Reply-To: <200806282055.45829.vladimir@codesourcery.com>

On Sat, Jun 28, 2008 at 08:55:45PM +0400, Vladimir Prus wrote:
> There are several strategies to accepting commands when inferior_ptid is
> running. One approach is to plain disallow all commands when inferior_ptid
> is running.  This seems too strict.  Clearly, setting ignore count of 
> a breakpoint does not require any access to the target at all.  Another 
> approach is to document which commands may be allowed when the target is 
> running. The problem is that each individual command may work or not work 
> depending on the properties of the target. 
> 
> So, it's better to allow all commands up-front, and emit an error if we 
> try an operation that the current target does not allow. This way, we'll 
> never mistakenly prevent an operation that the target actually can perform.
> In case of error, the frontend may show the error to the user, and user 
> change either change his mind, or explicitly stop a thread, or ask the 
> frontend to implicitly interrupt the target, or ask gdb to do same.
> 
> OK?
> 
> - Volodya
> 
> 	* gdb/top.c (execute_command_1): Don't check if the inferiour
> 	is running.

What does this do to the quality of error messages?  Particularly for
targets other than Linux, or targets with async but not non-stop.

It's true that we'll have to get rid of this eventually, but can we do
it without having to think about each command individually?

"ignore" is an interesting example.  If a breakpoint has been ignored
twice and you lower the ignore count to one while the target is
running do we need to stop?

-- 
Daniel Jacobowitz
CodeSourcery


      parent reply	other threads:[~2008-07-11 13:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-28 16:58 Vladimir Prus
2008-07-11 13:46 ` Pedro Alves
2008-07-11 18:59   ` Vladimir Prus
2008-07-11 19:04     ` Daniel Jacobowitz
2008-07-11 19:12       ` Pedro Alves
2008-07-13  4:26       ` Daniel Jacobowitz
2008-07-13  4:35         ` Vladimir Prus
2008-07-11 13:46 ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080711134548.GD2651@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox