From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26114 invoked by alias); 28 Jun 2008 16:56:05 -0000 Received: (qmail 26104 invoked by uid 22791); 28 Jun 2008 16:56:04 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 28 Jun 2008 16:55:47 +0000 Received: (qmail 11197 invoked from network); 28 Jun 2008 16:55:45 -0000 Received: from unknown (HELO 172.16.unknown.plus.ru) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Jun 2008 16:55:45 -0000 From: Vladimir Prus Date: Sat, 28 Jun 2008 16:58:00 -0000 Subject: [MI non-stop 07/11, RFA] Allow all CLI command even if target is executing. To: gdb-patches@sources.redhat.com X-TUID: f67e571685050924 X-Length: 2156 X-UID: 266 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806282055.45829.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00546.txt.bz2 There are several strategies to accepting commands when inferior_ptid is running. One approach is to plain disallow all commands when inferior_ptid is running. This seems too strict. Clearly, setting ignore count of a breakpoint does not require any access to the target at all. Another approach is to document which commands may be allowed when the target is running. The problem is that each individual command may work or not work depending on the properties of the target. So, it's better to allow all commands up-front, and emit an error if we try an operation that the current target does not allow. This way, we'll never mistakenly prevent an operation that the target actually can perform. In case of error, the frontend may show the error to the user, and user change either change his mind, or explicitly stop a thread, or ask the frontend to implicitly interrupt the target, or ask gdb to do same. OK? - Volodya * gdb/top.c (execute_command_1): Don't check if the inferiour is running. --- gdb/top.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/gdb/top.c b/gdb/top.c index e09ccaa..a891a43 100644 --- a/gdb/top.c +++ b/gdb/top.c @@ -444,14 +444,6 @@ execute_command_1 (char *p, int from_tty, int internal) && !get_cmd_no_selected_thread_ok (c)) error (_("\ Cannot execute this command without a selected thread. See `help thread'")); - /* If the target is running, we allow only a limited set of - commands. */ - else if (target_can_async_p () - && target_has_execution - && ((!non_stop && any_running ()) - || (non_stop && is_running (inferior_ptid))) - && !get_cmd_async_ok (c)) - error (_("Cannot execute this command while the target is running.")); /* Pass null arg rather than an empty one. */ arg = *p ? p : 0; -- 1.5.3.5