From: Daniel Jacobowitz <drow@false.org>
To: Luis Machado <luisgpm@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Listing cpp source code in mainless binaries
Date: Thu, 26 Jun 2008 14:42:00 -0000 [thread overview]
Message-ID: <20080626141754.GJ22726@caradoc.them.org> (raw)
In-Reply-To: <1213122525.10042.148.camel@gargoyle>
On Tue, Jun 10, 2008 at 03:28:45PM -0300, Luis Machado wrote:
> - /* All right; find the last file in the symtab list (ignoring .h's). */
> + /* All right; find the last file in the symtab list (ignoring .h's)
> + and namespace symtabs. */
That should be inside the parentheses :-)
> @@ -260,7 +261,8 @@
> {
> const char *name = s->filename;
> int len = strlen (name);
> - if (!(len > 2 && strcmp(&name[len - 2], ".h") == 0))
> + if (!(len > 2 && (strcmp (&name[len - 2], ".h") == 0
> + || strcmp (name, "<<C++-namespaces>>") == 0)))
> current_source_symtab = s;
> }
> }
>
Also, the same check is needed a few lines down. Otherwise OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-06-26 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 22:04 Luis Machado
2008-06-26 14:42 ` Daniel Jacobowitz [this message]
2008-06-30 14:13 ` Luis Machado
2008-06-30 18:04 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080626141754.GJ22726@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox