Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: luisgpm@linux.vnet.ibm.com
Cc: Daniel Jacobowitz <drow@false.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Listing cpp source code in mainless binaries
Date: Mon, 30 Jun 2008 18:04:00 -0000	[thread overview]
Message-ID: <je63rr3ssg.fsf@sykes.suse.de> (raw)
In-Reply-To: <1214834098.21286.46.camel@gargoyle> (Luis Machado's message of 	"Mon, 30 Jun 2008 10:54:58 -0300")

Luis Machado <luisgpm@linux.vnet.ibm.com> writes:

> @@ -260,14 +261,15 @@
>  	{
>  	  const char *name = s->filename;
>  	  int len = strlen (name);
> -	  if (!(len > 2 && strcmp(&name[len - 2], ".h") == 0))
> +	  if (!(len > 2 && (strcmp (&name[len - 2], ".h") == 0
> +	      || strcmp (name, "<<C++-namespaces>>") == 0)))

Indentation is wrong here.

> @@ -275,7 +277,8 @@
>  	{
>  	  const char *name = ps->filename;
>  	  int len = strlen (name);
> -	  if (!(len > 2 && strcmp (&name[len - 2], ".h") == 0))
> +	  if (!(len > 2 && (strcmp (&name[len - 2], ".h") == 0
> +	      || strcmp (name, "<<C++-namespaces>>") == 0)))

Likewise.  Alternatively, drop the inner pair of parens, the semantics
will be the same.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


      reply	other threads:[~2008-06-30 14:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-10 22:04 Luis Machado
2008-06-26 14:42 ` Daniel Jacobowitz
2008-06-30 14:13   ` Luis Machado
2008-06-30 18:04     ` Andreas Schwab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=je63rr3ssg.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=luisgpm@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox