From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-56862-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24890 invoked by alias); 26 Jun 2008 14:18:23 -0000
Received: (qmail 24862 invoked by uid 22791); 26 Jun 2008 14:18:16 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 26 Jun 2008 14:17:57 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id 6FC7D98411; 	Thu, 26 Jun 2008 14:17:55 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id 59B5B9835A; 	Thu, 26 Jun 2008 14:17:55 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69) 	(envelope-from <drow@caradoc.them.org>) 	id 1KBsIM-0007E9-Nc; Thu, 26 Jun 2008 10:17:54 -0400
Date: Thu, 26 Jun 2008 14:42:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Luis Machado <luisgpm@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Listing cpp source code in mainless binaries
Message-ID: <20080626141754.GJ22726@caradoc.them.org>
Mail-Followup-To: Luis Machado <luisgpm@linux.vnet.ibm.com>, 	gdb-patches@sourceware.org
References: <1213122525.10042.148.camel@gargoyle>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1213122525.10042.148.camel@gargoyle>
User-Agent: Mutt/1.5.17 (2008-05-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-06/txt/msg00476.txt.bz2

On Tue, Jun 10, 2008 at 03:28:45PM -0300, Luis Machado wrote:
> -  /* All right; find the last file in the symtab list (ignoring .h's).  */
> +  /* All right; find the last file in the symtab list (ignoring .h's)
> +     and namespace symtabs.  */

That should be inside the parentheses :-)

> @@ -260,7 +261,8 @@
>  	{
>  	  const char *name = s->filename;
>  	  int len = strlen (name);
> -	  if (!(len > 2 && strcmp(&name[len - 2], ".h") == 0))
> +	  if (!(len > 2 && (strcmp (&name[len - 2], ".h") == 0
> +	      || strcmp (name, "<<C++-namespaces>>") == 0)))
>  	    current_source_symtab = s;
>  	}
>      }
> 

Also, the same check is needed a few lines down.  Otherwise OK.

-- 
Daniel Jacobowitz
CodeSourcery