Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@specifix.com>
Cc: Daniel Jacobowitz <drow@false.org>, gdb-patches@sourceware.org
Subject: Re: [RFA] set/show enable-software-singlestep
Date: Wed, 25 Jun 2008 13:22:00 -0000	[thread overview]
Message-ID: <20080625125424.GC3700@adacore.com> (raw)
In-Reply-To: <1214335528.3601.1216.camel@localhost.localdomain>

Hi Michael,

> 2008-06-23  Michael Snyder  <msnyder@specifix.com>
> 
> 	* infrun.c (can_use_sw_ss): New mode variable.
> 	(show_can_use_sw_ss): New setshow helper function.
> 	(resume): Check for can-use-software-singlestep.
> 	(_initialize_infrun): Add set/show command for 
> 	can-use-software-singlestep.

As discussed previously on gdb@, I think this is a useful feature
even outside of reverse debugging.  Regarding Pedro's question
about making this feature transparent, that would be tough for
the example I gave, which is Tru64 - we want to be able to use
s/w single-step only on programs that use threads. To make it automatic,
we'd have to reliably detect that a program uses threads. Perhaps
this is doable, but having the option is an easy first step. Later
on, we can always extend the option to a tri-state with an "auto"
setting if it helps...

The code itself looks good, but I'm not so sure about accessing this
feature through a "maint" command. Since in my eyes it's a feature,
I'd personally be inclined to make it accessible through  "set/show
can-use-software-singlestep".  It is an obscure feature, however, so
I'm not really that concerned about it. How about we wait for another
week to see if we have any other comment; if not, then just commit
as is.

-- 
Joel


  reply	other threads:[~2008-06-25 12:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 18:43 Michael Snyder
2008-06-24 19:15 ` Daniel Jacobowitz
2008-06-24 19:32   ` Michael Snyder
2008-06-25 13:22     ` Joel Brobecker [this message]
2008-06-25 13:43       ` Daniel Jacobowitz
2008-06-25 14:15         ` Joel Brobecker
2008-06-25 14:33         ` Pedro Alves
2008-06-25 15:05           ` Daniel Jacobowitz
2008-06-25 15:38             ` Pedro Alves
     [not found]               ` <1214862215.3601.1525.camel@localhost.localdomain>
2008-07-10  2:46                 ` Michael Snyder
2008-07-10 11:07                   ` Pedro Alves
2008-07-10 22:47                     ` Daniel Jacobowitz
2008-07-12  2:31                       ` Michael Snyder
2008-07-12  2:28                     ` Michael Snyder
2008-06-25 14:35       ` Pedro Alves
2008-06-25 14:42         ` Joel Brobecker
2008-06-24 19:25 ` Eli Zaretskii
2008-06-24 19:34 ` Luis Machado
2008-06-24 20:22   ` Michael Snyder
2008-06-25  1:40 ` Pedro Alves
2008-06-25  6:15   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080625125424.GC3700@adacore.com \
    --to=brobecker@adacore.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@specifix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox