From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31507 invoked by alias); 25 Jun 2008 12:54:46 -0000 Received: (qmail 31499 invoked by uid 22791); 25 Jun 2008 12:54:45 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jun 2008 12:54:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 10E012A95C9; Wed, 25 Jun 2008 08:54:26 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id pAE3w68ikCAF; Wed, 25 Jun 2008 08:54:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2E42D2A95C5; Wed, 25 Jun 2008 08:54:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E2F72E7ACD; Wed, 25 Jun 2008 08:54:24 -0400 (EDT) Date: Wed, 25 Jun 2008 13:22:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: Daniel Jacobowitz , gdb-patches@sourceware.org Subject: Re: [RFA] set/show enable-software-singlestep Message-ID: <20080625125424.GC3700@adacore.com> References: <1214331534.3601.1211.camel@localhost.localdomain> <20080624182933.GA12195@caradoc.them.org> <1214335528.3601.1216.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1214335528.3601.1216.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00426.txt.bz2 Hi Michael, > 2008-06-23 Michael Snyder > > * infrun.c (can_use_sw_ss): New mode variable. > (show_can_use_sw_ss): New setshow helper function. > (resume): Check for can-use-software-singlestep. > (_initialize_infrun): Add set/show command for > can-use-software-singlestep. As discussed previously on gdb@, I think this is a useful feature even outside of reverse debugging. Regarding Pedro's question about making this feature transparent, that would be tough for the example I gave, which is Tru64 - we want to be able to use s/w single-step only on programs that use threads. To make it automatic, we'd have to reliably detect that a program uses threads. Perhaps this is doable, but having the option is an easy first step. Later on, we can always extend the option to a tri-state with an "auto" setting if it helps... The code itself looks good, but I'm not so sure about accessing this feature through a "maint" command. Since in my eyes it's a feature, I'd personally be inclined to make it accessible through "set/show can-use-software-singlestep". It is an obscure feature, however, so I'm not really that concerned about it. How about we wait for another week to see if we have any other comment; if not, then just commit as is. -- Joel