Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Nick Roberts <nickrob@snap.net.nz>,  Daniel Jacobowitz <drow@false.org>
Subject: Re: [PATCH] Another annotation for threads
Date: Fri, 06 Jun 2008 02:39:00 -0000	[thread overview]
Message-ID: <200806060338.51693.pedro@codesourcery.com> (raw)
In-Reply-To: <18504.35208.397231.7949@kahikatea.snap.net.nz>

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

A Friday 06 June 2008 01:49:12, Nick Roberts wrote:
> Daniel Jacobowitz writes:

>                                    ... but the patch is OK.
>
> Committed.  Thanks.

2008-05-21  Nick Roberts  <nickrob@snap.net.nz>

        * annotate.c (annotate_thread_changed): New function.
        * thread.c (thread_command) : Use it.
        * infrun.c (normal_stop): Use it.

This broke the build, as the annotate_thread_changed function isn't
declared anywhere.

I checked the attached in, as obvious.

Out of curiosity, was there a reason you committed every file as
individual commits?  It's customary to do a patch per commit
(not that is matter that much with CVS, but still nice to be
able to correlate by date, and to look at gdb-cvs).

-- 
Pedro Alves

[-- Attachment #2: annotate.diff --]
[-- Type: text/x-diff, Size: 591 bytes --]

2008-06-06  Pedro Alves  <pedro@codesourcery.com>

	* annotate.h (annotate_thread_changed): Declare.

---
 gdb/annotate.h |    1 +
 1 file changed, 1 insertion(+)

Index: src/gdb/annotate.h
===================================================================
--- src.orig/gdb/annotate.h	2008-06-06 03:27:03.000000000 +0100
+++ src/gdb/annotate.h	2008-06-06 03:27:44.000000000 +0100
@@ -44,6 +44,7 @@ extern void annotate_breakpoints_table_e
 
 extern void annotate_frames_invalid (void);
 extern void annotate_new_thread (void);
+extern void annotate_thread_changed (void);
 
 struct type;
 

  parent reply	other threads:[~2008-06-06  2:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21  6:13 Nick Roberts
2008-05-21  8:54 ` Eli Zaretskii
2008-06-05 19:30 ` Daniel Jacobowitz
2008-06-05 21:20   ` Nick Roberts
2008-06-05 21:26     ` Daniel Jacobowitz
2008-06-05 22:02       ` Joel Brobecker
2008-06-06  1:03         ` Nick Roberts
2008-06-06  6:59           ` Joel Brobecker
2008-06-06  0:50       ` Nick Roberts
2008-06-06  1:06         ` Tom Tromey
2008-06-06  2:30           ` Daniel Jacobowitz
2008-06-06  2:44             ` Tom Tromey
2008-06-06  2:39         ` Pedro Alves [this message]
2008-06-06  3:00           ` Nick Roberts
2008-06-06 11:44             ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806060338.51693.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox