From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Another annotation for threads
Date: Thu, 05 Jun 2008 21:26:00 -0000 [thread overview]
Message-ID: <20080605212615.GA6969@caradoc.them.org> (raw)
In-Reply-To: <18504.22662.394416.990603@kahikatea.snap.net.nz>
On Fri, Jun 06, 2008 at 09:20:06AM +1200, Nick Roberts wrote:
> > > If this patch is OK, I will submit a similar one for MI using an observer.
> >
> > It's quite likely that I've gotten turned around in all the discussion
> > while I was away, and you've already answered this. But here's my
> > question anyway: if there's going to be an observer to do this in MI,
> > why shouldn't annotate.c use the same observer to call
> > annotate_thread_changed?
>
> For the same reason that the "new-thread" annotation was eventually done
> without annotations: GDB/MI developers might decide to call it at other
> locations.
>
> Also it means it has the same idiom as all the other annotations and, on it's
> own, it's a simple change that's not very intrusive.
I don't find that very convincing, but the patch is OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-06-05 21:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 6:13 Nick Roberts
2008-05-21 8:54 ` Eli Zaretskii
2008-06-05 19:30 ` Daniel Jacobowitz
2008-06-05 21:20 ` Nick Roberts
2008-06-05 21:26 ` Daniel Jacobowitz [this message]
2008-06-05 22:02 ` Joel Brobecker
2008-06-06 1:03 ` Nick Roberts
2008-06-06 6:59 ` Joel Brobecker
2008-06-06 0:50 ` Nick Roberts
2008-06-06 1:06 ` Tom Tromey
2008-06-06 2:30 ` Daniel Jacobowitz
2008-06-06 2:44 ` Tom Tromey
2008-06-06 2:39 ` Pedro Alves
2008-06-06 3:00 ` Nick Roberts
2008-06-06 11:44 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605212615.GA6969@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox