From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25701 invoked by alias); 6 Jun 2008 02:39:08 -0000 Received: (qmail 25683 invoked by uid 22791); 6 Jun 2008 02:39:07 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 06 Jun 2008 02:38:49 +0000 Received: (qmail 7787 invoked from network); 6 Jun 2008 02:38:47 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Jun 2008 02:38:47 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH] Another annotation for threads Date: Fri, 06 Jun 2008 02:39:00 -0000 User-Agent: KMail/1.9.9 Cc: Nick Roberts , Daniel Jacobowitz References: <18483.36546.101715.670386@kahikatea.snap.net.nz> <20080605212615.GA6969@caradoc.them.org> <18504.35208.397231.7949@kahikatea.snap.net.nz> In-Reply-To: <18504.35208.397231.7949@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_7MKSIiKLhcFAwKZ" Message-Id: <200806060338.51693.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00098.txt.bz2 --Boundary-00=_7MKSIiKLhcFAwKZ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-length: 808 A Friday 06 June 2008 01:49:12, Nick Roberts wrote: > Daniel Jacobowitz writes: > ... but the patch is OK. > > Committed. Thanks. 2008-05-21 =A0Nick Roberts =A0 =A0=A0=A0=A0=A0=A0=A0=A0* annotate.c (annotate_thread_changed): New functio= n. =A0=A0=A0=A0=A0=A0=A0=A0* thread.c (thread_command) : Use it. =A0=A0=A0=A0=A0=A0=A0=A0* infrun.c (normal_stop): Use it. This broke the build, as the annotate_thread_changed function isn't declared anywhere. I checked the attached in, as obvious. Out of curiosity, was there a reason you committed every file as individual commits? It's customary to do a patch per commit (not that is matter that much with CVS, but still nice to be able to correlate by date, and to look at gdb-cvs). --=20 Pedro Alves --Boundary-00=_7MKSIiKLhcFAwKZ Content-Type: text/x-diff; charset="iso-8859-1"; name="annotate.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="annotate.diff" Content-length: 591 2008-06-06 Pedro Alves * annotate.h (annotate_thread_changed): Declare. --- gdb/annotate.h | 1 + 1 file changed, 1 insertion(+) Index: src/gdb/annotate.h =================================================================== --- src.orig/gdb/annotate.h 2008-06-06 03:27:03.000000000 +0100 +++ src/gdb/annotate.h 2008-06-06 03:27:44.000000000 +0100 @@ -44,6 +44,7 @@ extern void annotate_breakpoints_table_e extern void annotate_frames_invalid (void); extern void annotate_new_thread (void); +extern void annotate_thread_changed (void); struct type; --Boundary-00=_7MKSIiKLhcFAwKZ--