From: Daniel Jacobowitz <drow@false.org>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org, Doug Evans <dje@google.com>,
Michael Snyder <msnyder@specifix.com>
Subject: Re: [RFC] Fix for mishandling of "break 'pthread_create@GLIBC_2.2.5'"
Date: Thu, 05 Jun 2008 19:14:00 -0000 [thread overview]
Message-ID: <20080605191340.GB25085@caradoc.them.org> (raw)
In-Reply-To: <8ac60eac0805131805m6216660ej7b8e859ce46cb084@mail.gmail.com>
On Tue, May 13, 2008 at 06:05:05PM -0700, Paul Pluzhnikov wrote:
> So the expression evaluation and the breakpoint evaluation go
> completely separate routes:
Ah, right. I tried nested functions in GCC, which have the same
problem.
(gdb) b 'bar.18<tab>
bar.1873 bar.1888
(gdb) b 'bar.1888'
Can't find member of namespace, class, struct, or union named "bar.1888"
> set_flags (*argptr, &is_quoted, &paren_pointer);
>
> - /* Check to see if it's a multipart linespec (with colons or
> - periods). */
> + if ((*argptr)[0] == '\'')
I believe this is the same as is_quoted. If I'm right, that implies
that this breaks:
(gdb) break 'foo.c':13
We need to call locate_first_half to separate the filename from the
line number. There's also the 'foo.c'::staticvar form to worry about.
I think locate_first_half is going to have to know whether is_quoted,
and if so, only look for the matching quote.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-06-05 19:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 19:11 Paul Pluzhnikov
2008-05-13 19:21 ` Daniel Jacobowitz
2008-05-13 22:16 ` Michael Snyder
2008-05-13 23:02 ` Paul Pluzhnikov
2008-05-13 23:16 ` Daniel Jacobowitz
2008-05-14 1:05 ` Paul Pluzhnikov
2008-05-14 8:16 ` Paul Pluzhnikov
2008-06-05 19:14 ` Daniel Jacobowitz [this message]
2008-06-06 2:14 ` Paul Pluzhnikov
2008-06-06 2:35 ` Daniel Jacobowitz
2008-05-14 4:26 ` David Miller
2008-05-14 4:30 ` Daniel Jacobowitz
2008-05-14 11:51 ` David Miller
2008-05-14 14:48 ` Daniel Jacobowitz
2008-05-14 17:33 ` David Miller
2008-05-14 18:05 ` Andreas Schwab
2008-05-14 18:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605191340.GB25085@caradoc.them.org \
--to=drow@false.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@specifix.com \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox