Re: [RFC] Fix for mishandling of "break 'pthread_create@GLIBC_2.2.5'"

["Paul Pluzhnikov" <ppluzhnikov@google.com>]

On Thu, Jun 5, 2008 at 12:13 PM, Daniel Jacobowitz <drow@false.org> wrote:
> On Tue, May 13, 2008 at 06:05:05PM -0700, Paul Pluzhnikov wrote:
>> So the expression evaluation and the breakpoint evaluation go
>> completely separate routes:
>
> Ah, right.  I tried nested functions in GCC, which have the same
> problem.

Yes, and the same fix should fix that as well :)

>>    set_flags (*argptr, &is_quoted, &paren_pointer);
>>
>> -  /* Check to see if it's a multipart linespec (with colons or
>> -     periods).  */
>> +  if ((*argptr)[0] == '\'')
>
> I believe this is the same as is_quoted.

You are correct.

> If I'm right, that implies that this breaks:
>
> (gdb) break 'foo.c':13

But that is *already* broken:

(gdb) b t.c:8
Breakpoint 1 at 0x400308: file t.c, line 8.
(gdb) b "t.c":8
Breakpoint 2 at 0x400308: file t.c, line 8.
(gdb) b 't.c':8
No source file named t.c'.
(gdb)

I can fix that (and I believe it should be fixed), but it appears
that single and double quotes are treated quite differently in
linespec.c

Is there maybe a reason for this?

> We need to call locate_first_half to separate the filename from the
> line number.  There's also the 'foo.c'::staticvar form to worry about.

That case already works correctly (remember -- variables go through
totally different path).

> I think locate_first_half is going to have to know whether is_quoted,
> and if so, only look for the matching quote.

Something like this:

@@ -1003,7 +1003,9 @@ locate_first_half (char **argptr, int *i

   /* Maybe arg is FILE : LINENUM or FILE : FUNCTION.  May also be
      CLASS::MEMBER, or NAMESPACE::NAME.  Look for ':', but ignore
-     inside of <>.  */
+     inside of <>.
+     May also be 'FILE' : LINENUM, or 'symbol@VERSION'. Ignore
+     any ':' or '.' inside single qoutes.  */

   p = *argptr;
   if (p[0] == '"')
@@ -1014,6 +1016,17 @@ locate_first_half (char **argptr, int *i
     }
   else
     *is_quote_enclosed = 0;
+
+  if (p[0] == '\'')
+    {
+      char *q = p + 1;
+      for (; *q && q[0] != '\''; q++) { }
+      if (q[0] == '\'')
+        q++;
+      else
+        error (_("missing closing quote in command"));
+      p = q;
+    }
   for (; *p; p++)
     {
       if (p[0] == '<')



-- 
Paul Pluzhnikov