From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7272 invoked by alias); 5 Jun 2008 19:14:03 -0000 Received: (qmail 7258 invoked by uid 22791); 5 Jun 2008 19:14:02 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 05 Jun 2008 19:13:43 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id B9DC998371; Thu, 5 Jun 2008 19:13:41 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 8A4F59809F; Thu, 5 Jun 2008 19:13:41 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1K4Ku4-0008GN-UT; Thu, 05 Jun 2008 15:13:40 -0400 Date: Thu, 05 Jun 2008 19:14:00 -0000 From: Daniel Jacobowitz To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org, Doug Evans , Michael Snyder Subject: Re: [RFC] Fix for mishandling of "break 'pthread_create@GLIBC_2.2.5'" Message-ID: <20080605191340.GB25085@caradoc.them.org> Mail-Followup-To: Paul Pluzhnikov , gdb-patches@sourceware.org, Doug Evans , Michael Snyder References: <8ac60eac0805131135h5e9dd46ev8b7f39e660bf0bb7@mail.gmail.com> <20080513184447.GA12349@caradoc.them.org> <8ac60eac0805131351s241d33a8pd7d9839c51e53a8d@mail.gmail.com> <20080513205941.GA21147@caradoc.them.org> <8ac60eac0805131411q443b8f3awa464e090a5a44aaf@mail.gmail.com> <8ac60eac0805131805m6216660ej7b8e859ce46cb084@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ac60eac0805131805m6216660ej7b8e859ce46cb084@mail.gmail.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00055.txt.bz2 On Tue, May 13, 2008 at 06:05:05PM -0700, Paul Pluzhnikov wrote: > So the expression evaluation and the breakpoint evaluation go > completely separate routes: Ah, right. I tried nested functions in GCC, which have the same problem. (gdb) b 'bar.18 bar.1873 bar.1888 (gdb) b 'bar.1888' Can't find member of namespace, class, struct, or union named "bar.1888" > set_flags (*argptr, &is_quoted, &paren_pointer); > > - /* Check to see if it's a multipart linespec (with colons or > - periods). */ > + if ((*argptr)[0] == '\'') I believe this is the same as is_quoted. If I'm right, that implies that this breaks: (gdb) break 'foo.c':13 We need to call locate_first_half to separate the filename from the line number. There's also the 'foo.c'::staticvar form to worry about. I think locate_first_half is going to have to know whether is_quoted, and if so, only look for the matching quote. -- Daniel Jacobowitz CodeSourcery