From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] 2/3: Fix crash on self-looping DW_OP_fbreg
Date: Thu, 05 Jun 2008 16:30:00 -0000 [thread overview]
Message-ID: <20080605163001.GG29085@caradoc.them.org> (raw)
In-Reply-To: <20080504131403.GA26995@host0.dyn.jankratochvil.net>
On Sun, May 04, 2008 at 03:14:03PM +0200, Jan Kratochvil wrote:
> On Thu, 01 May 2008 22:29:04 +0200, Daniel Jacobowitz wrote:
> ...
> > OK. Do we need a cleanup for this though? If we error out, we won't
> > get back until we create a new context, so missing the decrement
> > is not a problem.
>
> I find it too fragile relying only on the current callers of DWARF_EXPR_EVAL.
> There may be a hard to catch bug after someone wraps some part of the code by
> CATCH_EXCEPTIONS and expects DWARF_EXPR_CONTEXT passed into the
> CATCH_EXCEPTIONS block will stay uncorrupted afterwards.
>
> Attached a discouraged simplified patch not using the exception system.
Thanks. Could you please commit this version?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-06-05 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 14:44 Jan Kratochvil
2008-05-01 20:29 ` Daniel Jacobowitz
2008-05-04 14:14 ` Jan Kratochvil
2008-06-05 16:30 ` Daniel Jacobowitz [this message]
2008-06-05 18:42 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605163001.GG29085@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox