From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] 2/3: Fix crash on self-looping DW_OP_fbreg
Date: Thu, 01 May 2008 20:29:00 -0000 [thread overview]
Message-ID: <20080501202903.GR22218@caradoc.them.org> (raw)
In-Reply-To: <20080428083732.GB12394@host0.dyn.jankratochvil.net>
On Mon, Apr 28, 2008 at 10:37:32AM +0200, Jan Kratochvil wrote:
> 2008-04-28 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * Makefile.in: Update dependencies.
> * dwarf2expr.c: New include "gdb_assert.h".
> (new_dwarf_expr_context): Initialize MAX_RECURSION_DEPTH.
> (struct dwarf_expr_eval_cleanup, dwarf_expr_eval_cleanup): New.
> (dwarf_expr_eval): Protect the RECURSION_DEPTH count for exceptions.
> (execute_stack_op): Error out on too large RECURSION_DEPTH.
> Increase/decrease RECURSION_DEPTH around the function.
OK. Do we need a cleanup for this though? If we error out, we won't
get back until we create a new context, so missing the decrement
is not a problem.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-05-01 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 14:44 Jan Kratochvil
2008-05-01 20:29 ` Daniel Jacobowitz [this message]
2008-05-04 14:14 ` Jan Kratochvil
2008-06-05 16:30 ` Daniel Jacobowitz
2008-06-05 18:42 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501202903.GR22218@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox