From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3416 invoked by alias); 1 May 2008 20:29:31 -0000 Received: (qmail 3406 invoked by uid 22791); 1 May 2008 20:29:30 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 May 2008 20:29:06 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D5879983D6; Thu, 1 May 2008 20:29:04 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id B903A98366; Thu, 1 May 2008 20:29:04 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JrfOq-0007pJ-16; Thu, 01 May 2008 16:29:04 -0400 Date: Thu, 01 May 2008 20:29:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] 2/3: Fix crash on self-looping DW_OP_fbreg Message-ID: <20080501202903.GR22218@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org References: <20080428083732.GB12394@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080428083732.GB12394@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00042.txt.bz2 On Mon, Apr 28, 2008 at 10:37:32AM +0200, Jan Kratochvil wrote: > 2008-04-28 Jan Kratochvil > > * Makefile.in: Update dependencies. > * dwarf2expr.c: New include "gdb_assert.h". > (new_dwarf_expr_context): Initialize MAX_RECURSION_DEPTH. > (struct dwarf_expr_eval_cleanup, dwarf_expr_eval_cleanup): New. > (dwarf_expr_eval): Protect the RECURSION_DEPTH count for exceptions. > (execute_stack_op): Error out on too large RECURSION_DEPTH. > Increase/decrease RECURSION_DEPTH around the function. OK. Do we need a cleanup for this though? If we error out, we won't get back until we create a new context, so missing the decrement is not a problem. -- Daniel Jacobowitz CodeSourcery