From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25046 invoked by alias); 5 Jun 2008 16:30:23 -0000 Received: (qmail 25034 invoked by uid 22791); 5 Jun 2008 16:30:23 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 05 Jun 2008 16:30:03 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 3D66698371; Thu, 5 Jun 2008 16:30:02 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 0DED99809F; Thu, 5 Jun 2008 16:30:02 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1K4ILh-0002wz-4p; Thu, 05 Jun 2008 12:30:01 -0400 Date: Thu, 05 Jun 2008 16:30:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] 2/3: Fix crash on self-looping DW_OP_fbreg Message-ID: <20080605163001.GG29085@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org References: <20080428083732.GB12394@host0.dyn.jankratochvil.net> <20080501202903.GR22218@caradoc.them.org> <20080504131403.GA26995@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080504131403.GA26995@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00037.txt.bz2 On Sun, May 04, 2008 at 03:14:03PM +0200, Jan Kratochvil wrote: > On Thu, 01 May 2008 22:29:04 +0200, Daniel Jacobowitz wrote: > ... > > OK. Do we need a cleanup for this though? If we error out, we won't > > get back until we create a new context, so missing the decrement > > is not a problem. > > I find it too fragile relying only on the current callers of DWARF_EXPR_EVAL. > There may be a hard to catch bug after someone wraps some part of the code by > CATCH_EXCEPTIONS and expects DWARF_EXPR_CONTEXT passed into the > CATCH_EXCEPTIONS block will stay uncorrupted afterwards. > > Attached a discouraged simplified patch not using the exception system. Thanks. Could you please commit this version? -- Daniel Jacobowitz CodeSourcery