From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch/mdebug] symbol symtab not set on Tru64
Date: Tue, 27 May 2008 23:23:00 -0000 [thread overview]
Message-ID: <20080527185819.GA4057@adacore.com> (raw)
In-Reply-To: <200805271820.m4RIKJlh025155@d12av02.megacenter.de.ibm.com>
> > As a result, we end up with SEGVs or failed assertions when trying
> > to access this field because it was NULL. Fixed thusly.
>
> Is this a regression due to my recent SYMBOL_SYMTAB cleanup patch?
Your patch might have made the problem more visible, not sure, but
the issue was introduced much earlier than this (I think early 2007),
when this new field was added. I noticed it a couple of weeks ago,
before you checked your cleanup patch in.
> > 2008-05-26 Joel Brobecker <brobecker@adacore.com>
> >
> > Set the symtab field of symbols read from ECOFF debugging entries.
> > * mdebugread.c (add_symbol): Add new parameter symtab.
> > (parse_symbol): Update calls to add_symbol throughout.
>
> In any case, this looks good to me ...
Thanks for double-checking it! I will check it in shortly.
--
Joel
next prev parent reply other threads:[~2008-05-27 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 18:58 Joel Brobecker
2008-05-27 18:58 ` Joel Brobecker
2008-05-27 19:20 ` Ulrich Weigand
2008-05-27 23:23 ` Joel Brobecker [this message]
2008-05-28 7:23 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080527185819.GA4057@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox