From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [patch/mdebug] symbol symtab not set on Tru64
Date: Tue, 27 May 2008 18:58:00 -0000 [thread overview]
Message-ID: <20080526161809.GD15798@adacore.com> (raw)
Hello,
Something I just noticed while working on alpha-tru64. When reading
symbols from ECOFF, the produced symbols do not have their symtab
field set. I did a little of archeology, and basically the reason
for it is because the symbol reader does its own symbol and symtab
building, rather than using buildsym. So when the symtab field
was added to struct symbol, we forgot to update part of mdebugread.c.
It's kind of confusing, because mdebugread also handles stabs-in-coff,
in which case buildsym.c is being used. This may be why we missed
the parts in mdebugread.c that needed an update.
As a result, we end up with SEGVs or failed assertions when trying
to access this field because it was NULL. Fixed thusly.
2008-05-26 Joel Brobecker <brobecker@adacore.com>
Set the symtab field of symbols read from ECOFF debugging entries.
* mdebugread.c (add_symbol): Add new parameter symtab.
(parse_symbol): Update calls to add_symbol throughout.
Tested on alpha-tru64 with the AdaCore testsuite (I can't seem to get
expect to work on Tru64 anymore - it looks like I have an echo issue).
I will commit in a week unless there are comments about the patch.
--
Joel
next reply other threads:[~2008-05-26 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 18:58 Joel Brobecker [this message]
2008-05-27 18:58 ` Joel Brobecker
2008-05-27 19:20 ` Ulrich Weigand
2008-05-27 23:23 ` Joel Brobecker
2008-05-28 7:23 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080526161809.GD15798@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox