From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2391 invoked by alias); 27 May 2008 18:58:43 -0000 Received: (qmail 2378 invoked by uid 22791); 27 May 2008 18:58:42 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 May 2008 18:58:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3F9D02A96AC; Tue, 27 May 2008 14:58:22 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0ujkrM582xop; Tue, 27 May 2008 14:58:22 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 031C92A95B2; Tue, 27 May 2008 14:58:22 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D206CE7ACD; Tue, 27 May 2008 11:58:19 -0700 (PDT) Date: Tue, 27 May 2008 23:23:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [patch/mdebug] symbol symtab not set on Tru64 Message-ID: <20080527185819.GA4057@adacore.com> References: <20080526162447.GL4080@adacore.com> <200805271820.m4RIKJlh025155@d12av02.megacenter.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200805271820.m4RIKJlh025155@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00716.txt.bz2 > > As a result, we end up with SEGVs or failed assertions when trying > > to access this field because it was NULL. Fixed thusly. > > Is this a regression due to my recent SYMBOL_SYMTAB cleanup patch? Your patch might have made the problem more visible, not sure, but the issue was introduced much earlier than this (I think early 2007), when this new field was added. I noticed it a couple of weeks ago, before you checked your cleanup patch in. > > 2008-05-26 Joel Brobecker > > > > Set the symtab field of symbols read from ECOFF debugging entries. > > * mdebugread.c (add_symbol): Add new parameter symtab. > > (parse_symbol): Update calls to add_symbol throughout. > > In any case, this looks good to me ... Thanks for double-checking it! I will check it in shortly. -- Joel