Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Fix MI/async testsuite
Date: Mon, 05 May 2008 09:15:00 -0000	[thread overview]
Message-ID: <200805051240.48055.vladimir@codesourcery.com> (raw)
In-Reply-To: <20080504195640.GA15966@caradoc.them.org>

On Sunday 04 May 2008 23:56:40 Daniel Jacobowitz wrote:
> On Sun, May 04, 2008 at 09:38:01PM +0400, Vladimir Prus wrote:
> > Well, ideally, ^running should not exist. When gdb is done with a command,
> > it should always print ^done, and since it's done with a command, print a
> > prompt. Unfortunately, right now ^running exists and does something fairly
> > strange:
> > 
> > - in sync mode, you get "^running" + "(gdb)" before even trying to resume
> > target
> > - in async mode you get "^running" + random output + "(gdb)"
> > - in async mode when running CLI command, you get "^running" + "^done"
> > 
> > This is a mess, but I don't think we should/can fix this mess without
> > going to MI3.
> 
> For MI2, why can't we leave ^running 

We can't "leave" it, because in async mode ^running is not immediately followed
by a prompt, now, and before any my changes. 

> always followed by a prompt?  We 
> fail to accept input at that prompt in sync mode, which is a known
> bug, but that's life.

I sure can make all ^running be followed by prompt, but that would be "fixing"
code to be as buggy as the other code. Does it worth the time?

> I don't think having ^result followed by =EVENT followed by (gdb)
> makes sense, 

I think it does -- and the MI spec I've just posted explicitly calls for
such behaviour for run commands:

1. First you get ^done, which means "Okay, nothing else to do about this command"
2. Then you get *running, =whatever, ..., *stopped

In async mode, you get prompt immediately after (1) -- because it's where gdb
is ready to accept commands. In sync mode, you get prompt after (2). Of course,
we can print ^done only after (2) in that case, but does it make sense?

- Volodya


  reply	other threads:[~2008-05-05  8:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-04 13:40 Vladimir Prus
2008-05-04 17:14 ` Daniel Jacobowitz
2008-05-04 17:22   ` Vladimir Prus
2008-05-04 17:29     ` Daniel Jacobowitz
2008-05-04 17:37       ` Daniel Jacobowitz
2008-05-04 19:02         ` Vladimir Prus
2008-05-04 20:05           ` Daniel Jacobowitz
2008-05-05  9:15             ` Vladimir Prus [this message]
2008-06-05 16:38               ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805051240.48055.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox