Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] bpstat_do_actions in one place
Date: Fri, 02 May 2008 02:58:00 -0000	[thread overview]
Message-ID: <20080502025753.GA28580@caradoc.them.org> (raw)
In-Reply-To: <200804242002.03590.vladimir@codesourcery.com>

On Thu, Apr 24, 2008 at 07:02:03PM +0300, Vladimir Prus wrote:
> 
> This patch, to be applied on top of the "Use observers to report stop events."
> make async code call bpstat_do_action in the event handler, to make sure that
> it's always called.
> 
> OK?

OK.

> +      /* If there's an error doing breakpoint commands, we don't
> +	 want to throw -- continuation might still do something.  */
> +      TRY_CATCH (e, RETURN_MASK_ERROR)
> +	{
> +	  bpstat_do_actions (&stop_bpstat);
> +	}

Will things go bad if RETURN_QUIT?  I discovered that we don't handle
quit very well from some places.

Easy to trigger; put a command that generates lots of paginated output
in the commands list and press q at the page prompt.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-05-02  2:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24 19:08 Vladimir Prus
2008-05-02  2:58 ` Daniel Jacobowitz [this message]
2008-05-05  9:56   ` Vladimir Prus
2008-05-05 13:06     ` Daniel Jacobowitz
2008-05-05 13:10       ` Vladimir Prus
2008-05-05 14:12         ` Daniel Jacobowitz
2008-05-05 20:47         ` Eli Zaretskii
2008-05-05 20:47           ` Daniel Jacobowitz
2008-05-05 20:53             ` Eli Zaretskii
2008-05-05 20:57               ` Daniel Jacobowitz
2008-05-06 15:46                 ` Eli Zaretskii
2008-05-06 15:47                   ` Daniel Jacobowitz
2008-05-06 19:24                     ` Eli Zaretskii
2008-05-06 20:04                       ` Daniel Jacobowitz
2008-05-07 11:38                         ` Eli Zaretskii
2008-05-07 19:50                           ` Daniel Jacobowitz
2008-05-08  4:23                             ` Eli Zaretskii
2008-05-08  5:46                               ` Daniel Jacobowitz
2008-05-08 11:34                                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080502025753.GA28580@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox