Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] bpstat_do_actions in one place
Date: Thu, 24 Apr 2008 19:08:00 -0000	[thread overview]
Message-ID: <200804242002.03590.vladimir@codesourcery.com> (raw)


This patch, to be applied on top of the "Use observers to report stop events."
make async code call bpstat_do_action in the event handler, to make sure that
it's always called.

OK?

- Volodya

---
 gdb/inf-loop.c |    7 +++++++
 gdb/top.c      |    2 --
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/inf-loop.c b/gdb/inf-loop.c
index 4c61dae..3b18abb 100644
--- a/gdb/inf-loop.c
+++ b/gdb/inf-loop.c
@@ -43,6 +43,7 @@ void
 inferior_event_handler (enum inferior_event_type event_type, 
 			gdb_client_data client_data)
 {
+  struct gdb_exception e;
   int was_sync = 0;
   switch (event_type)
     {
@@ -91,6 +92,12 @@ inferior_event_handler (enum inferior_event_type event_type,
       was_sync = sync_execution;
       async_enable_stdin ();
 
+      /* If there's an error doing breakpoint commands, we don't
+	 want to throw -- continuation might still do something.  */
+      TRY_CATCH (e, RETURN_MASK_ERROR)
+	{
+	  bpstat_do_actions (&stop_bpstat);
+	}
       /* If we were doing a multi-step (eg: step n, next n), but it
 	 got interrupted by a breakpoint, still do the pending
 	 continuations.  The continuation itself is responsible for
diff --git a/gdb/top.c b/gdb/top.c
index 2454d24..feefcf0 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -379,8 +379,6 @@ command_line_handler_continuation (struct continuation_arg *arg, int error)
   if (error)
     return;
 
-  bpstat_do_actions (&stop_bpstat);
-
   if (display_time)
     {
       long cmd_time = get_run_time () - time_at_cmd_start;
-- 
1.5.3.5


             reply	other threads:[~2008-04-24 16:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24 19:08 Vladimir Prus [this message]
2008-05-02  2:58 ` Daniel Jacobowitz
2008-05-05  9:56   ` Vladimir Prus
2008-05-05 13:06     ` Daniel Jacobowitz
2008-05-05 13:10       ` Vladimir Prus
2008-05-05 14:12         ` Daniel Jacobowitz
2008-05-05 20:47         ` Eli Zaretskii
2008-05-05 20:47           ` Daniel Jacobowitz
2008-05-05 20:53             ` Eli Zaretskii
2008-05-05 20:57               ` Daniel Jacobowitz
2008-05-06 15:46                 ` Eli Zaretskii
2008-05-06 15:47                   ` Daniel Jacobowitz
2008-05-06 19:24                     ` Eli Zaretskii
2008-05-06 20:04                       ` Daniel Jacobowitz
2008-05-07 11:38                         ` Eli Zaretskii
2008-05-07 19:50                           ` Daniel Jacobowitz
2008-05-08  4:23                             ` Eli Zaretskii
2008-05-08  5:46                               ` Daniel Jacobowitz
2008-05-08 11:34                                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804242002.03590.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox