From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30913 invoked by alias); 2 May 2008 02:58:18 -0000 Received: (qmail 30888 invoked by uid 22791); 2 May 2008 02:58:15 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 May 2008 02:57:56 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 6A3A5983D6; Fri, 2 May 2008 02:57:54 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 3871E98366; Fri, 2 May 2008 02:57:54 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JrlT7-0007Td-2i; Thu, 01 May 2008 22:57:53 -0400 Date: Fri, 02 May 2008 02:58:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] bpstat_do_actions in one place Message-ID: <20080502025753.GA28580@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200804242002.03590.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200804242002.03590.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00057.txt.bz2 On Thu, Apr 24, 2008 at 07:02:03PM +0300, Vladimir Prus wrote: > > This patch, to be applied on top of the "Use observers to report stop events." > make async code call bpstat_do_action in the event handler, to make sure that > it's always called. > > OK? OK. > + /* If there's an error doing breakpoint commands, we don't > + want to throw -- continuation might still do something. */ > + TRY_CATCH (e, RETURN_MASK_ERROR) > + { > + bpstat_do_actions (&stop_bpstat); > + } Will things go bad if RETURN_QUIT? I discovered that we don't handle quit very well from some places. Easy to trigger; put a command that generates lots of paginated output in the commands list and press q at the page prompt. -- Daniel Jacobowitz CodeSourcery