Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [rfc] Unwind the ARM CPSR
Date: Thu, 01 May 2008 18:35:00 -0000	[thread overview]
Message-ID: <20080501183510.GB2875@caradoc.them.org> (raw)
In-Reply-To: <20080501183048.GA2875@caradoc.them.org>

On Thu, May 01, 2008 at 02:30:48PM -0400, Daniel Jacobowitz wrote:
> That place is now gone.  I've tested this version on arm-none-eabi
> (where it fixes one failure with -mthumb, gdb.base/ending-run.exp:
> step to end of run) and on arm-none-symbianelf.
> 
> Checked in.

Correction to that patch.  Sorry, this got tangled up in the other
patch I'm testing.

-- 
Daniel Jacobowitz
CodeSourcery

Index: src/gdb/arm-tdep.c
===================================================================
--- src.orig/gdb/arm-tdep.c	2008-05-01 13:56:01.000000000 -0400
+++ src/gdb/arm-tdep.c	2008-05-01 13:56:33.000000000 -0400
@@ -1162,15 +1190,13 @@ arm_dwarf2_prev_register (struct frame_i
 
     case ARM_PS_REGNUM:
       /* Reconstruct the T bit; see arm_prologue_prev_register for details.  */
-      CORE_ADDR lr, cpsr;
-
-      cpsr = get_frame_register_unsigned (this_frame, prev_regnum);
+      cpsr = get_frame_register_unsigned (this_frame, regnum);
       lr = frame_unwind_register_unsigned (this_frame, ARM_LR_REGNUM);
       if (IS_THUMB_ADDR (lr))
 	cpsr |= CPSR_T;
       else
 	cpsr &= ~CPSR_T;
-      return frame_unwind_got_constant (this_frame, prev_regnum, cpsr);
+      return frame_unwind_got_constant (this_frame, regnum, cpsr);
 
     default:
       internal_error (__FILE__, __LINE__,


      reply	other threads:[~2008-05-01 18:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-11 14:59 Daniel Jacobowitz
2007-10-11 15:52 ` Daniel Jacobowitz
2007-10-12  8:08 ` Joel Brobecker
2007-10-16 22:09   ` Mark Kettenis
2007-10-17  0:36     ` Daniel Jacobowitz
2007-10-17  6:05       ` Daniel Jacobowitz
2007-10-17 13:18         ` Joel Brobecker
2007-10-19 11:54         ` Ulrich Weigand
2007-10-17  0:30 ` Mark Kettenis
2008-05-01 18:31 ` Daniel Jacobowitz
2008-05-01 18:35   ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080501183510.GB2875@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox