From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10802 invoked by alias); 1 May 2008 18:35:43 -0000 Received: (qmail 10794 invoked by uid 22791); 1 May 2008 18:35:43 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 May 2008 18:35:14 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7A5C8983D6 for ; Thu, 1 May 2008 18:35:12 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 4FD0A98366 for ; Thu, 1 May 2008 18:35:12 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Jrdcc-0005ls-KI for gdb-patches@sourceware.org; Thu, 01 May 2008 14:35:10 -0400 Date: Thu, 01 May 2008 18:35:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [rfc] Unwind the ARM CPSR Message-ID: <20080501183510.GB2875@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20071011145137.GA18336@caradoc.them.org> <20080501183048.GA2875@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080501183048.GA2875@caradoc.them.org> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00018.txt.bz2 On Thu, May 01, 2008 at 02:30:48PM -0400, Daniel Jacobowitz wrote: > That place is now gone. I've tested this version on arm-none-eabi > (where it fixes one failure with -mthumb, gdb.base/ending-run.exp: > step to end of run) and on arm-none-symbianelf. > > Checked in. Correction to that patch. Sorry, this got tangled up in the other patch I'm testing. -- Daniel Jacobowitz CodeSourcery Index: src/gdb/arm-tdep.c =================================================================== --- src.orig/gdb/arm-tdep.c 2008-05-01 13:56:01.000000000 -0400 +++ src/gdb/arm-tdep.c 2008-05-01 13:56:33.000000000 -0400 @@ -1162,15 +1190,13 @@ arm_dwarf2_prev_register (struct frame_i case ARM_PS_REGNUM: /* Reconstruct the T bit; see arm_prologue_prev_register for details. */ - CORE_ADDR lr, cpsr; - - cpsr = get_frame_register_unsigned (this_frame, prev_regnum); + cpsr = get_frame_register_unsigned (this_frame, regnum); lr = frame_unwind_register_unsigned (this_frame, ARM_LR_REGNUM); if (IS_THUMB_ADDR (lr)) cpsr |= CPSR_T; else cpsr &= ~CPSR_T; - return frame_unwind_got_constant (this_frame, prev_regnum, cpsr); + return frame_unwind_got_constant (this_frame, regnum, cpsr); default: internal_error (__FILE__, __LINE__,