Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org, Mark Kettenis <kettenis@gnu.org>,
		Jim Blandy <jimb@codesourcery.com>
Subject: Re: [rfc] Unwind the ARM CPSR
Date: Thu, 11 Oct 2007 15:52:00 -0000	[thread overview]
Message-ID: <20071011145918.GA19988@caradoc.them.org> (raw)
In-Reply-To: <20071011145137.GA18336@caradoc.them.org>

On Thu, Oct 11, 2007 at 10:51:37AM -0400, Daniel Jacobowitz wrote:
> So why shouldn't the argument be the CURRENT (i.e. THIS) frame
> instead?  Then we can call frame_register (CURRENT) instead of
> frame_unwind_register (NEXT) to get the same result, plus we'll
> have the option of calling frame_unwind_register (CURRENT) when
> we need it.
> 
> Of course this would be a pain to change all at once since there are
> so many unwinders.  I'd introduce a new method instead
> (unwind->prev_register_this?).  What do you think?  Is there some
> reason I didn't think of why it would be naughty to use the current
> frame instead of the next one?

By the way, if I'm going to be changing the prev_register interface,
the other thing I've thought of doing is making it return a struct
value instead of filling in a pile of value-like fields (register
number, address, lval, et cetera).  I am a little worried about how
this would affect watchpoints on local variables though.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-10-11 14:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-11 14:59 Daniel Jacobowitz
2007-10-11 15:52 ` Daniel Jacobowitz [this message]
2007-10-12  8:08 ` Joel Brobecker
2007-10-16 22:09   ` Mark Kettenis
2007-10-17  0:36     ` Daniel Jacobowitz
2007-10-17  6:05       ` Daniel Jacobowitz
2007-10-17 13:18         ` Joel Brobecker
2007-10-19 11:54         ` Ulrich Weigand
2007-10-17  0:30 ` Mark Kettenis
2008-05-01 18:31 ` Daniel Jacobowitz
2008-05-01 18:35   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071011145918.GA19988@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jimb@codesourcery.com \
    --cc=kettenis@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox