From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sources.redhat.com
Subject: [commit] print breakpoint address only once (branch?)
Date: Thu, 17 Apr 2008 23:08:00 -0000 [thread overview]
Message-ID: <20080417224447.GG12735@adacore.com> (raw)
In-Reply-To: <20080417212523.GA7870@caradoc.them.org>
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
> > Let me know if you'd like me to fix this.
>
> Yes please.
Ok, fixed thusly:
2008-04-17 Joel Brobecker <brobecker@adacore.com>
* breakpoint.c (print_one_breakpoint_location): Make sure to print
the breakpoint address only once.
Tested on x86-linux, no regression.
I think this should probably go in 6.8 as well. Any objection?
--
Joel
[-- Attachment #2: bp.diff --]
[-- Type: text/plain, Size: 694 bytes --]
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.308
diff -u -p -r1.308 breakpoint.c
--- breakpoint.c 15 Apr 2008 14:32:12 -0000 1.308
+++ breakpoint.c 17 Apr 2008 22:41:53 -0000
@@ -3607,7 +3607,7 @@ print_one_breakpoint_location (struct br
annotate_field (4);
if (header_of_multiple)
ui_out_field_string (uiout, "addr", "<MULTIPLE>");
- if (b->loc == NULL || loc->shlib_disabled)
+ else if (b->loc == NULL || loc->shlib_disabled)
ui_out_field_string (uiout, "addr", "<PENDING>");
else
ui_out_field_core_addr (uiout, "addr", loc->address);
next prev parent reply other threads:[~2008-04-17 22:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 11:52 [RFA/RFC] Report the original location specification for a breakpoint Vladimir Prus
2008-04-17 9:16 ` Daniel Jacobowitz
2008-04-17 11:52 ` Vladimir Prus
2008-04-17 12:35 ` Nick Roberts
2008-04-17 15:28 ` Vladimir Prus
2008-04-17 21:17 ` Nick Roberts
2008-04-17 17:51 ` Daniel Jacobowitz
2008-04-17 21:25 ` Joel Brobecker
2008-04-17 21:31 ` Daniel Jacobowitz
2008-04-17 23:08 ` Joel Brobecker [this message]
2008-04-17 23:21 ` [commit] print breakpoint address only once (branch?) Daniel Jacobowitz
2008-04-19 2:08 ` Joel Brobecker
2008-04-24 11:45 ` [RFA/RFC] Report the original location specification for a breakpoint Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080417224447.GG12735@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox