From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/RFC] Report the original location specification for a breakpoint.
Date: Thu, 17 Apr 2008 09:16:00 -0000 [thread overview]
Message-ID: <20080417025749.GA18352@caradoc.them.org> (raw)
In-Reply-To: <200804151434.57665.vladimir@codesourcery.com>
On Tue, Apr 15, 2008 at 02:34:57PM +0400, Vladimir Prus wrote:
> This patch adds the necessary MI support for reporting the original location.
> It's not ready to be checked in because MI testsuite will likely break all over.
> OTOH, I've tested this with KDevelop4, and it works just fine. I'll fix this
> before committing.
>
> Is this patch OK?
>
> In fact, I wonder if I can commit patches like this, that touch files
> outside of MI code but apparently change behaviour only for MI, without
> approval. Any comments?
Isn't this going to affect more than MI? I thought the text from
ui_out_field_string was displayed for console too, just without the
label.
This definitely needs documentation to go in. I can't say this
enough. Undocumented fields in the MI output might as well not exist.
Beyond those, I don't see a problem with it. Though wouldn't we like
to display this in the CLI sometimes too?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-04-17 2:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 11:52 Vladimir Prus
2008-04-17 9:16 ` Daniel Jacobowitz [this message]
2008-04-17 11:52 ` Vladimir Prus
2008-04-17 12:35 ` Nick Roberts
2008-04-17 15:28 ` Vladimir Prus
2008-04-17 21:17 ` Nick Roberts
2008-04-17 17:51 ` Daniel Jacobowitz
2008-04-17 21:25 ` Joel Brobecker
2008-04-17 21:31 ` Daniel Jacobowitz
2008-04-17 23:08 ` [commit] print breakpoint address only once (branch?) Joel Brobecker
2008-04-17 23:21 ` Daniel Jacobowitz
2008-04-19 2:08 ` Joel Brobecker
2008-04-24 11:45 ` [RFA/RFC] Report the original location specification for a breakpoint Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080417025749.GA18352@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox