From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc/rft] ppc gdbserver: autodetect AltiVec and SPE
Date: Thu, 17 Apr 2008 21:34:00 -0000 [thread overview]
Message-ID: <200804172129.m3HLTENG005880@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20080417184739.GQ17488@caradoc.them.org> from "Daniel Jacobowitz" at Apr 17, 2008 02:47:39 PM
Daniel Jacobowitz wrote:
> It looks like we've fallen afoul of the code which fetches the
> first register set, then if it is not available does not try any
> further register sets. So when we try PTRACE_GETVRREGS and fail
> we never try PTRACE_GETEVRREGS.
>
> This code's bitten me before. It's even worse now, because if which
> ptrace operations succeed depends on the inferior's mode, the values
> may change during multi. So I've pulled it out. The attached patch,
> combined with yours, produces no regressions on any of (SPE, AltiVec,
> classic PowerPC).
Ah, good catch. Thank you very much for testing my patch (and fixing
the problems!).
> Want to check them both in?
Sure, I've now checked them in.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2008-04-17 21:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 1:11 [rfc][3/3] gdbserver bi-arch for ppc: enable bi-arch support Ulrich Weigand
2008-02-27 13:20 ` Daniel Jacobowitz
2008-02-28 7:16 ` Ulrich Weigand
2008-02-28 14:13 ` Daniel Jacobowitz
2008-02-28 17:03 ` [rfc/rft] ppc gdbserver: autodetect AltiVec and SPE Ulrich Weigand
2008-02-28 17:12 ` Daniel Jacobowitz
2008-03-26 20:21 ` Ulrich Weigand
2008-04-19 0:19 ` Thiago Jung Bauermann
2008-04-19 6:17 ` Daniel Jacobowitz
2008-04-20 14:28 ` Thiago Jung Bauermann
2008-04-21 9:21 ` Daniel Jacobowitz
2008-04-21 10:00 ` Thiago Jung Bauermann
2008-04-21 14:04 ` Ulrich Weigand
2008-04-21 14:32 ` Daniel Jacobowitz
2008-04-21 15:36 ` Ulrich Weigand
2008-04-21 15:38 ` Daniel Jacobowitz
2008-04-17 17:47 ` Daniel Jacobowitz
2008-04-17 19:03 ` Daniel Jacobowitz
2008-04-17 21:34 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804172129.m3HLTENG005880@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox