From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4372 invoked by alias); 17 Apr 2008 21:29:40 -0000 Received: (qmail 4353 invoked by uid 22791); 17 Apr 2008 21:29:40 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Apr 2008 21:29:18 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id m3HLTFMH090356 for ; Thu, 17 Apr 2008 21:29:15 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m3HLTFk63780826 for ; Thu, 17 Apr 2008 23:29:15 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m3HLTF2r005883 for ; Thu, 17 Apr 2008 23:29:15 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m3HLTENG005880; Thu, 17 Apr 2008 23:29:14 +0200 Message-Id: <200804172129.m3HLTENG005880@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 17 Apr 2008 23:29:14 +0200 Subject: Re: [rfc/rft] ppc gdbserver: autodetect AltiVec and SPE To: drow@false.org (Daniel Jacobowitz) Date: Thu, 17 Apr 2008 21:34:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20080417184739.GQ17488@caradoc.them.org> from "Daniel Jacobowitz" at Apr 17, 2008 02:47:39 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00370.txt.bz2 Daniel Jacobowitz wrote: > It looks like we've fallen afoul of the code which fetches the > first register set, then if it is not available does not try any > further register sets. So when we try PTRACE_GETVRREGS and fail > we never try PTRACE_GETEVRREGS. > > This code's bitten me before. It's even worse now, because if which > ptrace operations succeed depends on the inferior's mode, the values > may change during multi. So I've pulled it out. The attached patch, > combined with yours, produces no regressions on any of (SPE, AltiVec, > classic PowerPC). Ah, good catch. Thank you very much for testing my patch (and fixing the problems!). > Want to check them both in? Sure, I've now checked them in. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com