Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: Ulrich Weigand <uweigand@de.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [rfc/rft] ppc gdbserver: autodetect AltiVec and SPE
Date: Mon, 21 Apr 2008 09:21:00 -0000	[thread overview]
Message-ID: <20080420142750.GA24305@caradoc.them.org> (raw)
In-Reply-To: <1208667119.5808.126.camel@localhost.localdomain>

On Sun, Apr 20, 2008 at 01:51:59AM -0300, Thiago Jung Bauermann wrote:
> No, it was a clean build. I got what's happening. The patch removed
> powerpc-e500.o from powerpc64-*-linux*, because e500 is 32-bit only. The
> call to init_registers_powerpc_e500 is protected by an #ifndef
> __powerpc64__, so it shouldn't be a problem. But in practice it is,
> because when using plain "../src/configure && make" in a ppc64 machine
> with a 32-bit default gcc, the target is autodetected to be
> powerpc64-unknown-linux-gnu. Thus, that call to
> init_registers_powerpc_e500 will be compiled in (it's a 32 bit
> compilation), but powerpc-e500.o won't be included (it's a powerpc64
> target).
> 
> Is such way of compiling 32-bit GDB in a ppc64 machine with 32-bit
> default gcc not supported? Must one always use --target option to
> configure in such case?

I see.  Anything is supported that we're willing to fix... The
simplest possible fix would be to add the e500 objects.  Does
gdbserver work OK with this patch?

-- 
Daniel Jacobowitz
CodeSourcery

2008-04-20  Daniel Jacobowitz  <dan@codesourcery.com>

	* configure.srv: Add e500 objects even for powerpc64.

Index: configure.srv
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
retrieving revision 1.33
diff -u -p -r1.33 configure.srv
--- configure.srv	17 Apr 2008 21:22:41 -0000	1.33
+++ configure.srv	20 Apr 2008 14:27:03 -0000
@@ -106,7 +106,7 @@ case "${target}" in
 			srv_linux_usrregs=yes
 			srv_linux_thread_db=yes
 			;;
-  powerpc64-*-linux*)	srv_regobj="reg-ppc.o powerpc-32.o"
+  powerpc64-*-linux*)	srv_regobj="reg-ppc.o powerpc-32.o powerpc-e500.o"
 			srv_regobj="${srv_regobj} reg-ppc64.o powerpc-64.o"
 			srv_tgtobj="linux-low.o linux-ppc-low.o"
 			srv_xmlfiles="rs6000/powerpc-32.xml"
@@ -115,6 +115,8 @@ case "${target}" in
 			srv_xmlfiles="${srv_xmlfiles} rs6000/power-fpu.xml"
 			srv_xmlfiles="${srv_xmlfiles} rs6000/powerpc-64.xml"
 			srv_xmlfiles="${srv_xmlfiles} rs6000/power64-core.xml"
+			srv_xmlfiles="${srv_xmlfiles} rs6000/powerpc-e500.xml"
+			srv_xmlfiles="${srv_xmlfiles} rs6000/power-spe.xml"
 			srv_linux_usrregs=yes
 			srv_linux_regsets=yes
 			srv_linux_thread_db=yes


  reply	other threads:[~2008-04-20 14:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08  1:11 [rfc][3/3] gdbserver bi-arch for ppc: enable bi-arch support Ulrich Weigand
2008-02-27 13:20 ` Daniel Jacobowitz
2008-02-28  7:16   ` Ulrich Weigand
2008-02-28 14:13     ` Daniel Jacobowitz
2008-02-28 17:03       ` [rfc/rft] ppc gdbserver: autodetect AltiVec and SPE Ulrich Weigand
2008-02-28 17:12         ` Daniel Jacobowitz
2008-03-26 20:21           ` Ulrich Weigand
2008-04-19  0:19             ` Thiago Jung Bauermann
2008-04-19  6:17               ` Daniel Jacobowitz
2008-04-20 14:28                 ` Thiago Jung Bauermann
2008-04-21  9:21                   ` Daniel Jacobowitz [this message]
2008-04-21 10:00                     ` Thiago Jung Bauermann
2008-04-21 14:04                       ` Ulrich Weigand
2008-04-21 14:32                         ` Daniel Jacobowitz
2008-04-21 15:36                           ` Ulrich Weigand
2008-04-21 15:38                             ` Daniel Jacobowitz
2008-04-17 17:47         ` Daniel Jacobowitz
2008-04-17 19:03           ` Daniel Jacobowitz
2008-04-17 21:34             ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080420142750.GA24305@caradoc.them.org \
    --to=drow@false.org \
    --cc=bauerman@br.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox