Re: RFC: Warn at quit that we will kill the program

[Daniel Jacobowitz <drow@false.org>]

On Wed, Feb 20, 2008 at 10:37:00AM -0500, Daniel Jacobowitz wrote:
> Sandra noticed that GDB's exit message does not say we're about to
> kill the running program.  In native debugging this is somewhat
> apparent (though not completely), but not in remote debugging.
> 
> What do you think of this patch?
>
> (Not tested yet; I see that the message appears in the testsuite, so
> it will require a testsuite update.)

Testsuite updated, tested x86_64-linux, checked in.

-- 
Daniel Jacobowitz
CodeSourcery

2008-03-21  Daniel Jacobowitz  <dan@codesourcery.com>

	* top.c (quit_confirm): Warn that we will kill the program.

2008-03-21  Daniel Jacobowitz  <dan@codesourcery.com>

	* gdb.threads/killed.exp, gdb.threads/manythreads.exp,
	gdb.threads/staticthreads.exp: Update exit query.

Index: top.c
===================================================================
RCS file: /cvs/src/src/gdb/top.c,v
retrieving revision 1.134
diff -u -p -r1.134 top.c
--- top.c	17 Mar 2008 14:06:11 -0000	1.134
+++ top.c	21 Mar 2008 14:32:14 -0000
@@ -1253,7 +1253,7 @@ quit_confirm (void)
       else if (attach_flag)
 	s = "The program is running.  Quit anyway (and detach it)? ";
       else
-	s = "The program is running.  Exit anyway? ";
+	s = "The program is running.  Quit anyway (and kill it)? ";
 
       if (!query ("%s", s))
 	return 0;
Index: testsuite/gdb.threads/killed.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/killed.exp,v
retrieving revision 1.10
diff -u -p -r1.10 killed.exp
--- testsuite/gdb.threads/killed.exp	1 Jan 2008 22:53:22 -0000	1.10
+++ testsuite/gdb.threads/killed.exp	21 Mar 2008 14:32:14 -0000
@@ -87,7 +87,7 @@ gdb_expect {
 # Try to quit.
 send_gdb "quit\n"
 gdb_expect {
-    -re "The program is running.  Exit anyway\\? \\(y or n\\) $" {
+    -re "The program is running.  Quit anyway \\(and kill it\\)\\? \\(y or n\\) $" {
         send_gdb "y\n"
         exp_continue
     }
Index: testsuite/gdb.threads/manythreads.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/manythreads.exp,v
retrieving revision 1.8
diff -u -p -r1.8 manythreads.exp
--- testsuite/gdb.threads/manythreads.exp	1 Jan 2008 22:53:22 -0000	1.8
+++ testsuite/gdb.threads/manythreads.exp	21 Mar 2008 14:32:14 -0000
@@ -133,7 +133,7 @@ gdb_test_multiple "" "stop threads 2" {
 } 
 
 gdb_test_multiple "quit" "GDB exits after stopping multithreaded program" {
-    -re "The program is running.  Exit anyway\\? \\(y or n\\) $" {
+    -re "The program is running.  Quit anyway \\(and kill it\\)\\? \\(y or n\\) $" {
 	send_gdb "y\n"
 	exp_continue
     }
Index: testsuite/gdb.threads/staticthreads.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/staticthreads.exp,v
retrieving revision 1.6
diff -u -p -r1.6 staticthreads.exp
--- testsuite/gdb.threads/staticthreads.exp	1 Jan 2008 22:53:22 -0000	1.6
+++ testsuite/gdb.threads/staticthreads.exp	21 Mar 2008 14:32:14 -0000
@@ -91,7 +91,7 @@ gdb_test_multiple "info threads" "$test"
 
 set test "GDB exits with static thread program"
 gdb_test_multiple "quit" "$test" {
-    -re "The program is running.  Exit anyway\\? \\(y or n\\) $" {
+    -re "The program is running.  Quit anyway \\(and kill it\\)\\? \\(y or n\\) $" {
 	send_gdb "y\n"
 	exp_continue
     }