Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: RFC: Warn at quit that we will kill the program
Date: Wed, 20 Feb 2008 15:37:00 -0000	[thread overview]
Message-ID: <20080220153700.GA13158@caradoc.them.org> (raw)

Sandra noticed that GDB's exit message does not say we're about to
kill the running program.  In native debugging this is somewhat
apparent (though not completely), but not in remote debugging.

What do you think of this patch?

(Not tested yet; I see that the message appears in the testsuite, so
it will require a testsuite update.)

-- 
Daniel Jacobowitz
CodeSourcery

2008-02-20  Daniel Jacobowitz  <dan@codesourcery.com>

	* top.c (quit_confirm): Warn that we will kill the program.

Index: top.c
===================================================================
RCS file: /cvs/src/src/gdb/top.c,v
retrieving revision 1.129
diff -u -p -r1.129 top.c
--- top.c	1 Jan 2008 22:53:13 -0000	1.129
+++ top.c	20 Feb 2008 15:32:26 -0000
@@ -1212,7 +1212,7 @@ quit_confirm (void)
       else if (attach_flag)
 	s = "The program is running.  Quit anyway (and detach it)? ";
       else
-	s = "The program is running.  Exit anyway? ";
+	s = "The program is running.  Quit anyway (and kill it)? ";
 
       if (!query ("%s", s))
 	return 0;


             reply	other threads:[~2008-02-20 15:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 15:37 Daniel Jacobowitz [this message]
2008-02-20 17:18 ` Joel Brobecker
2008-02-20 20:19 ` Michael Snyder
2008-02-21  1:50   ` Daniel Jacobowitz
2008-02-21 22:11     ` Michael Snyder
2008-03-21 14:40 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080220153700.GA13158@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox