From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32232 invoked by alias); 20 Feb 2008 15:37:24 -0000 Received: (qmail 32197 invoked by uid 22791); 20 Feb 2008 15:37:24 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 20 Feb 2008 15:37:04 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 2D3549802E for ; Wed, 20 Feb 2008 15:37:02 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 091E79802B for ; Wed, 20 Feb 2008 15:37:02 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JRr0G-0003Tx-Rk for gdb-patches@sourceware.org; Wed, 20 Feb 2008 10:37:00 -0500 Date: Wed, 20 Feb 2008 15:37:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: RFC: Warn at quit that we will kill the program Message-ID: <20080220153700.GA13158@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00329.txt.bz2 Sandra noticed that GDB's exit message does not say we're about to kill the running program. In native debugging this is somewhat apparent (though not completely), but not in remote debugging. What do you think of this patch? (Not tested yet; I see that the message appears in the testsuite, so it will require a testsuite update.) -- Daniel Jacobowitz CodeSourcery 2008-02-20 Daniel Jacobowitz * top.c (quit_confirm): Warn that we will kill the program. Index: top.c =================================================================== RCS file: /cvs/src/src/gdb/top.c,v retrieving revision 1.129 diff -u -p -r1.129 top.c --- top.c 1 Jan 2008 22:53:13 -0000 1.129 +++ top.c 20 Feb 2008 15:32:26 -0000 @@ -1212,7 +1212,7 @@ quit_confirm (void) else if (attach_flag) s = "The program is running. Quit anyway (and detach it)? "; else - s = "The program is running. Exit anyway? "; + s = "The program is running. Quit anyway (and kill it)? "; if (!query ("%s", s)) return 0;