From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19671 invoked by alias); 21 Mar 2008 14:40:09 -0000 Received: (qmail 19662 invoked by uid 22791); 21 Mar 2008 14:40:09 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Mar 2008 14:39:49 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D953798298 for ; Fri, 21 Mar 2008 14:39:47 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id AC4CB98278 for ; Fri, 21 Mar 2008 14:39:47 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JciPK-0005t5-Ow for gdb-patches@sourceware.org; Fri, 21 Mar 2008 10:39:46 -0400 Date: Fri, 21 Mar 2008 14:40:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: RFC: Warn at quit that we will kill the program Message-ID: <20080321143946.GA25307@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20080220153700.GA13158@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080220153700.GA13158@caradoc.them.org> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00299.txt.bz2 On Wed, Feb 20, 2008 at 10:37:00AM -0500, Daniel Jacobowitz wrote: > Sandra noticed that GDB's exit message does not say we're about to > kill the running program. In native debugging this is somewhat > apparent (though not completely), but not in remote debugging. > > What do you think of this patch? > > (Not tested yet; I see that the message appears in the testsuite, so > it will require a testsuite update.) Testsuite updated, tested x86_64-linux, checked in. -- Daniel Jacobowitz CodeSourcery 2008-03-21 Daniel Jacobowitz * top.c (quit_confirm): Warn that we will kill the program. 2008-03-21 Daniel Jacobowitz * gdb.threads/killed.exp, gdb.threads/manythreads.exp, gdb.threads/staticthreads.exp: Update exit query. Index: top.c =================================================================== RCS file: /cvs/src/src/gdb/top.c,v retrieving revision 1.134 diff -u -p -r1.134 top.c --- top.c 17 Mar 2008 14:06:11 -0000 1.134 +++ top.c 21 Mar 2008 14:32:14 -0000 @@ -1253,7 +1253,7 @@ quit_confirm (void) else if (attach_flag) s = "The program is running. Quit anyway (and detach it)? "; else - s = "The program is running. Exit anyway? "; + s = "The program is running. Quit anyway (and kill it)? "; if (!query ("%s", s)) return 0; Index: testsuite/gdb.threads/killed.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/killed.exp,v retrieving revision 1.10 diff -u -p -r1.10 killed.exp --- testsuite/gdb.threads/killed.exp 1 Jan 2008 22:53:22 -0000 1.10 +++ testsuite/gdb.threads/killed.exp 21 Mar 2008 14:32:14 -0000 @@ -87,7 +87,7 @@ gdb_expect { # Try to quit. send_gdb "quit\n" gdb_expect { - -re "The program is running. Exit anyway\\? \\(y or n\\) $" { + -re "The program is running. Quit anyway \\(and kill it\\)\\? \\(y or n\\) $" { send_gdb "y\n" exp_continue } Index: testsuite/gdb.threads/manythreads.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/manythreads.exp,v retrieving revision 1.8 diff -u -p -r1.8 manythreads.exp --- testsuite/gdb.threads/manythreads.exp 1 Jan 2008 22:53:22 -0000 1.8 +++ testsuite/gdb.threads/manythreads.exp 21 Mar 2008 14:32:14 -0000 @@ -133,7 +133,7 @@ gdb_test_multiple "" "stop threads 2" { } gdb_test_multiple "quit" "GDB exits after stopping multithreaded program" { - -re "The program is running. Exit anyway\\? \\(y or n\\) $" { + -re "The program is running. Quit anyway \\(and kill it\\)\\? \\(y or n\\) $" { send_gdb "y\n" exp_continue } Index: testsuite/gdb.threads/staticthreads.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/staticthreads.exp,v retrieving revision 1.6 diff -u -p -r1.6 staticthreads.exp --- testsuite/gdb.threads/staticthreads.exp 1 Jan 2008 22:53:22 -0000 1.6 +++ testsuite/gdb.threads/staticthreads.exp 21 Mar 2008 14:32:14 -0000 @@ -91,7 +91,7 @@ gdb_test_multiple "info threads" "$test" set test "GDB exits with static thread program" gdb_test_multiple "quit" "$test" { - -re "The program is running. Exit anyway\\? \\(y or n\\) $" { + -re "The program is running. Quit anyway \\(and kill it\\)\\? \\(y or n\\) $" { send_gdb "y\n" exp_continue }