Restore building gdb

Restore building gdb

[Pedro Alves]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

One of my previous patches added an unguarded access to
inferior_process_group, which is only defined if
PROCESS_GROUP_TYPE is defined.

#ifdef PROCESS_GROUP_TYPE
/* Process group for us and the inferior.  Saved and restored just like
   {our,inferior}_ttystate.  */
PROCESS_GROUP_TYPE our_process_group;
PROCESS_GROUP_TYPE inferior_process_group;
#endif

This patch should fix it.

-- 
Pedro Alves

[-- Attachment #2: fix_inferior_process_group.diff --]
[-- Type: text/x-diff, Size: 992 bytes --]

2008-03-19  Pedro Alves  <pedro@codesourcery.com>

	* inflow.c (terminal_ours_1): Guard access to
	inferior_process_group with #ifdef PROCESS_GROUP_TYPE.

---
 gdb/inflow.c |    2 ++
 1 file changed, 2 insertions(+)

Index: src/gdb/inflow.c
===================================================================
--- src.orig/gdb/inflow.c	2008-03-19 14:26:18.000000000 +0000
+++ src/gdb/inflow.c	2008-03-19 14:26:34.000000000 +0000
@@ -350,11 +350,13 @@ terminal_ours_1 (int output_only)
 	xfree (inferior_ttystate);
       inferior_ttystate = serial_get_tty_state (stdin_serial);
 
+#ifdef PROCESS_GROUP_TYPE
       if (!attach_flag)
 	/* If setpgrp failed in terminal_inferior, this would give us
 	   our process group instead of the inferior's.  See
 	   terminal_inferior for details.  */
 	inferior_process_group = gdb_getpgrp ();
+#endif
 
       /* Here we used to set ICANON in our ttystate, but I believe this
          was an artifact from before when we used readline.  Readline sets

Re: Restore building gdb

[Daniel Jacobowitz]

On Wed, Mar 19, 2008 at 02:35:53PM +0000, Pedro Alves wrote:
> One of my previous patches added an unguarded access to
> inferior_process_group, which is only defined if
> PROCESS_GROUP_TYPE is defined.
> 
> #ifdef PROCESS_GROUP_TYPE
> /* Process group for us and the inferior.  Saved and restored just like
>    {our,inferior}_ttystate.  */
> PROCESS_GROUP_TYPE our_process_group;
> PROCESS_GROUP_TYPE inferior_process_group;
> #endif
> 
> This patch should fix it.
> 
> -- 
> Pedro Alves

> 2008-03-19  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* inflow.c (terminal_ours_1): Guard access to
> 	inferior_process_group with #ifdef PROCESS_GROUP_TYPE.

OK, thanks for the quick fix.

-- 
Daniel Jacobowitz
CodeSourcery

Re: Restore building gdb

[Pedro Alves]

A Wednesday 19 March 2008 14:42:13, Daniel Jacobowitz wrote:
> >
> > 2008-03-19  Pedro Alves  <pedro@codesourcery.com>
> >
> > 	* inflow.c (terminal_ours_1): Guard access to
> > 	inferior_process_group with #ifdef PROCESS_GROUP_TYPE.
>
> OK, thanks for the quick fix.

It's in now.  Thanks for the quick review.

-- 
Pedro Alves