From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Restore building gdb
Date: Wed, 19 Mar 2008 14:36:00 -0000 [thread overview]
Message-ID: <200803191435.53551.pedro@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
One of my previous patches added an unguarded access to
inferior_process_group, which is only defined if
PROCESS_GROUP_TYPE is defined.
#ifdef PROCESS_GROUP_TYPE
/* Process group for us and the inferior. Saved and restored just like
{our,inferior}_ttystate. */
PROCESS_GROUP_TYPE our_process_group;
PROCESS_GROUP_TYPE inferior_process_group;
#endif
This patch should fix it.
--
Pedro Alves
[-- Attachment #2: fix_inferior_process_group.diff --]
[-- Type: text/x-diff, Size: 992 bytes --]
2008-03-19 Pedro Alves <pedro@codesourcery.com>
* inflow.c (terminal_ours_1): Guard access to
inferior_process_group with #ifdef PROCESS_GROUP_TYPE.
---
gdb/inflow.c | 2 ++
1 file changed, 2 insertions(+)
Index: src/gdb/inflow.c
===================================================================
--- src.orig/gdb/inflow.c 2008-03-19 14:26:18.000000000 +0000
+++ src/gdb/inflow.c 2008-03-19 14:26:34.000000000 +0000
@@ -350,11 +350,13 @@ terminal_ours_1 (int output_only)
xfree (inferior_ttystate);
inferior_ttystate = serial_get_tty_state (stdin_serial);
+#ifdef PROCESS_GROUP_TYPE
if (!attach_flag)
/* If setpgrp failed in terminal_inferior, this would give us
our process group instead of the inferior's. See
terminal_inferior for details. */
inferior_process_group = gdb_getpgrp ();
+#endif
/* Here we used to set ICANON in our ttystate, but I believe this
was an artifact from before when we used readline. Readline sets
next reply other threads:[~2008-03-19 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 14:36 Pedro Alves [this message]
2008-03-19 14:42 ` Daniel Jacobowitz
2008-03-19 14:57 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803191435.53551.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox