Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: In async mode, use target_stop to stop the inferior
Date: Fri, 14 Mar 2008 14:39:00 -0000	[thread overview]
Message-ID: <20080314143845.GB18511@caradoc.them.org> (raw)
In-Reply-To: <200803140802.01625.pedro@codesourcery.com>

On Fri, Mar 14, 2008 at 08:02:01AM +0000, Pedro Alves wrote:
> We do have a target method for this now.  Obviouly for every
> async target other than "target (extended-)async", this wasn't
> working.
> 
> Installed as obvious (after testing with a local gdbserver with
> the testsuite and manually).

Sorry, but I don't think this is right.  Or else it deserves a better
explanation :-)  async_remote_interrupt_twice didn't stop the target;
it was used to escape from a hung remote target (see interrupt_query).

You can trace the twisty path that got here through
sigint_remote_twice_token.  I'm not sure what INF_QUIT_REQ should do,
or if it's necessary - I find inferior_event_handler a bit weird.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-03-14 14:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14  8:02 Pedro Alves
2008-03-14 14:39 ` Daniel Jacobowitz [this message]
2008-03-14 15:19   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080314143845.GB18511@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox