From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12977 invoked by alias); 14 Mar 2008 14:39:14 -0000 Received: (qmail 12969 invoked by uid 22791); 14 Mar 2008 14:39:14 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Mar 2008 14:38:48 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 732A1983B5; Fri, 14 Mar 2008 14:38:46 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 5DA9F983AA; Fri, 14 Mar 2008 14:38:46 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JaB3V-0004uN-La; Fri, 14 Mar 2008 10:38:45 -0400 Date: Fri, 14 Mar 2008 14:39:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: In async mode, use target_stop to stop the inferior Message-ID: <20080314143845.GB18511@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200803140802.01625.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200803140802.01625.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00172.txt.bz2 On Fri, Mar 14, 2008 at 08:02:01AM +0000, Pedro Alves wrote: > We do have a target method for this now. Obviouly for every > async target other than "target (extended-)async", this wasn't > working. > > Installed as obvious (after testing with a local gdbserver with > the testsuite and manually). Sorry, but I don't think this is right. Or else it deserves a better explanation :-) async_remote_interrupt_twice didn't stop the target; it was used to escape from a hung remote target (see interrupt_query). You can trace the twisty path that got here through sigint_remote_twice_token. I'm not sure what INF_QUIT_REQ should do, or if it's necessary - I find inferior_event_handler a bit weird. -- Daniel Jacobowitz CodeSourcery